Enrico Granata has posted comments on this change. ( https://review.coreboot.org/28112 )
Change subject: nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs ......................................................................
Patch Set 1:
(2 comments)
Two lines of patch & two comments. Good ratio there :-)
https://review.coreboot.org/#/c/28112/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nocturne/devicetree.cb:
https://review.coreboot.org/#/c/28112/1/src/mainboard/google/poppy/variants/... PS1, Line 312: register "reg_prox_ctrl10" = "0x1F"
nit: 1f
Done
https://review.coreboot.org/#/c/28112/1/src/mainboard/google/poppy/variants/... PS1, Line 353: register "reg_prox_ctrl10" = "0x1F"
nit: 1f
Done