Attention is currently required from: Ana Carolina Cabral, Fred Reitberger, Jason Glenesk, Matt DeVillier, Nick Kochlowski, Paul Menzel.
Matt DeVillier has posted comments on this change by Nick Kochlowski. ( https://review.coreboot.org/c/coreboot/+/84915?usp=email )
Change subject: soc/amd/phoenix/chip.c: Add PHX OpenSIL POC TP2/TP3 calls
......................................................................
Patch Set 7:
(1 comment)
File src/soc/amd/phoenix/chip.c:
https://review.coreboot.org/c/coreboot/+/84915/comment/63081c9a_81a9b613?usp... :
PS6, Line 41: default:
: break;
Is an empty default block good practice? I wouldn't think so, but maybe there's some reason I don't […]
the latest patchset prints an error in the default case
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84915?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8c335211bf36118fe1d6b7dacbf4064c1d7d3a38
Gerrit-Change-Number: 84915
Gerrit-PatchSet: 7
Gerrit-Owner: Nick Kochlowski
nickkochlowski@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ana Carolina Cabral
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Kochlowski
nickkochlowski@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Ana Carolina Cabral
Gerrit-Comment-Date: Wed, 04 Dec 2024 17:35:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Kochlowski
nickkochlowski@gmail.com
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com