[S] Change in coreboot[main]: mb/google/fatcat/var/francka: move NC pin to default

[Subrata Banik (Code Review)]

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87062?usp=email )

Change subject: mb/google/fatcat/var/francka: move NC pin to default
......................................................................

mb/google/fatcat/var/francka: move NC pin to default

Relocate the NC pins configuration to gpio.c, enabling it once needed.

BUG=b:392007428
TEST=emerge-fatcat coreboot

Signed-off-by: Mac Chiang 
Change-Id: I5c594f68b151f8c8c58e35a0590be15456f54b32
Reviewed-on: https://review.coreboot.org/c/coreboot/+/87062
Reviewed-by: Jayvik Desai 
Tested-by: build bot (Jenkins) 
Reviewed-by: Pranava Y N 
Reviewed-by: Kapil Porwal 
Reviewed-by: Subrata Banik 
---
M src/mainboard/google/fatcat/variants/francka/fw_config.c
M src/mainboard/google/fatcat/variants/francka/gpio.c
2 files changed, 16 insertions(+), 33 deletions(-)

Approvals:
  Pranava Y N: Looks good to me, approved
  Kapil Porwal: Looks good to me, approved
  Subrata Banik: Looks good to me, approved
  build bot (Jenkins): Verified
  Jayvik Desai: Looks good to me, approved

diff --git a/src/mainboard/google/fatcat/variants/francka/fw_config.c b/src/mainboard/google/fatcat/variants/francka/fw_config.c
index 91aa200..f904974 100644
--- a/src/mainboard/google/fatcat/variants/francka/fw_config.c
+++ b/src/mainboard/google/fatcat/variants/francka/fw_config.c
@@ -24,23 +24,6 @@
    PAD_CFG_NF(GPP_S06, NONE, DEEP, NF5),
    /* SOC_DMIC_DATA1 */
    PAD_CFG_NF(GPP_S07, NONE, DEEP, NF5),
-
-	/* GPP_D09:     PCH_DGPU_HOLD_RST#_R */
-	PAD_NC(GPP_D09, NONE),
-	/* GPP_D16:     HDA_RST# */
-	PAD_NC(GPP_D16, NONE),
-	/* GPP_S00:     SNDW_3_SCL */
-	PAD_NC(GPP_S00, NONE),
-	/* GPP_S01:     SNDW_3_SDA */
-	PAD_NC(GPP_S01, NONE),
-	/* GPP_S02:     SOC_DMIC_CLK0 */
-	PAD_NC(GPP_S02, NONE),
-	/* GPP_S03:     SOC_DMIC_DATA0 */
-	PAD_NC(GPP_S03, NONE),
-	/* GPP_S04:     SNDW2_CLK */
-	PAD_NC(GPP_S04, NONE),
-	/* GPP_S05:     SNDW2_DATA0 */
-	PAD_NC(GPP_S05, NONE),
 };

static const struct pad_config audio_disable_pads[] = {
diff --git a/src/mainboard/google/fatcat/variants/francka/gpio.c b/src/mainboard/google/fatcat/variants/francka/gpio.c
index 73898dc..baf272e 100644
--- a/src/mainboard/google/fatcat/variants/francka/gpio.c
+++ b/src/mainboard/google/fatcat/variants/francka/gpio.c
@@ -344,22 +344,22 @@
    /* GPP_H22:     SOC_I2C_1_SCL */
    PAD_CFG_NF(GPP_H22, NONE, DEEP, NF1),

-	/* GPP_S00:     SNDW_3_SCL */
-	PAD_CFG_NF(GPP_S00, NONE, DEEP, NF1),
-	/* GPP_S01:     SNDW_3_SDA */
-	PAD_CFG_NF(GPP_S01, NONE, DEEP, NF1),
-	/* GPP_S02:     SOC_DMIC_CLK0 */
-	PAD_CFG_NF(GPP_S02, NONE, DEEP, NF1),
-	/* GPP_S03:     SOC_DMIC_DATA0 */
-	PAD_CFG_NF(GPP_S03, NONE, DEEP, NF1),
-	/* GPP_S04:     SNDW2_CLK */
-	PAD_CFG_NF(GPP_S04, NONE, DEEP, NF2),
-	/* GPP_S05:     SNDW2_DATA0 */
-	PAD_CFG_NF(GPP_S05, NONE, DEEP, NF2),
-	/* GPP_S06:     SOC_DMIC_CLK1 */
-	PAD_CFG_NF(GPP_S06, NONE, DEEP, NF5),
-	/* GPP_S07:     SOC_DMIC_DATA1 */
-	PAD_CFG_NF(GPP_S07, NONE, DEEP, NF5),
+	/* GPP_S00:     Not used */
+	PAD_NC(GPP_S00, NONE),
+	/* GPP_S01:     Not used */
+	PAD_NC(GPP_S01, NONE),
+	/* GPP_S02:     Not used */
+	PAD_NC(GPP_S02, NONE),
+	/* GPP_S03:     Not used */
+	PAD_NC(GPP_S03, NONE),
+	/* GPP_S04:     Not used */
+	PAD_NC(GPP_S04, NONE),
+	/* GPP_S05:     Not used */
+	PAD_NC(GPP_S05, NONE),
+	/* GPP_S06:     Not used */
+	PAD_NC(GPP_S06, NONE),
+	/* GPP_S07:     Not used */
+	PAD_NC(GPP_S07, NONE),

/* GPP_V00:     PM_BATLOW# */
    PAD_CFG_NF(GPP_V00, NONE, DEEP, NF1),