Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Ravindra, Sridhar Siricilla, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55364 )
Change subject: soc/intel/alderlake: Trigger cse_fw_sync before DRAM Init ......................................................................
Patch Set 12:
(3 comments)
File src/soc/intel/alderlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/55364/comment/cc0ca5d8_56456ba0 PS12, Line 145: cse_fw_sync() must be called after DRAM initialization as : * HMRFPO_ENABLE HECI command (which is used by cse_fw_sync()) : * is expected to be executed after DRAM initialization. what happen to this recommendation. This comment looks like an advisory which we don't care now ?
Any reason for this ? if yes, can we highlight the same in commit msg as well
https://review.coreboot.org/c/coreboot/+/55364/comment/968f19fe_88edc0fd PS12, Line 140: can we add a timestamp around this to know how much time we are really spending for this command if possible ?
https://review.coreboot.org/c/coreboot/+/55364/comment/2a728c78_bb6658c8 PS12, Line 142: cse_fw_sync can you move this call immediately after heci_init() ?