Hello Aamir Bohra,
I'd like you to do a code review. Please visit
https://review.coreboot.org/29696
to review the following change.
Change subject: util/ifdtool: Add IceLake platform support under IFDv2 ......................................................................
util/ifdtool: Add IceLake platform support under IFDv2
Change-Id: Ib69a2cbc3d8ab9f35c940e95b0edb4b04b50b716 Signed-off-by: Aamir Bohra aamir.bohra@intel.com Reviewed-on: https://chromium-review.googlesource.com/1162995 Commit-Ready: ChromeOS CL Exonerator Bot chromiumos-cl-exonerator@appspot.gserviceaccount.com Tested-by: Subrata Banik subrata.banik@intel.com Reviewed-by: Subrata Banik subrata.banik@intel.com Reviewed-by: Shelley Chen shchen@chromium.org --- M util/ifdtool/ifdtool.c M util/ifdtool/ifdtool.h 2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/29696/1
diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 671c7d5..ccd27d0 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -214,6 +214,7 @@ static const int ifd_2_platforms[] = { PLATFORM_GLK, PLATFORM_CNL, + PLATFORM_ICL, }; unsigned int i;
@@ -1542,6 +1543,8 @@ platform = PLATFORM_CNL; } else if (!strcmp(optarg, "glk")) { platform = PLATFORM_GLK; + } else if (!strcmp(optarg, "icl")) { + platform = PLATFORM_ICL; } else if (!strcmp(optarg, "sklkbl")) { platform = PLATFORM_SKLKBL; } else { diff --git a/util/ifdtool/ifdtool.h b/util/ifdtool/ifdtool.h index aec7c30..49463b9 100644 --- a/util/ifdtool/ifdtool.h +++ b/util/ifdtool/ifdtool.h @@ -56,6 +56,7 @@ PLATFORM_APL, PLATFORM_CNL, PLATFORM_GLK, + PLATFORM_ICL, PLATFORM_SKLKBL, };