Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/28117 )
Change subject: sandybridge/raminit_common.c: fix printram statement ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
This fix is fine ofcourse, but the proper fix would be to replace all references to printram with printk(RAM_DEBUG, ...) or printk(RAM_SPEW, ...) in which case the code still gets compile tested.
https://review.coreboot.org/#/c/28117/1/src/northbridge/intel/sandybridge/ra... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/#/c/28117/1/src/northbridge/intel/sandybridge/ra... PS1, Line 210: printram( You avoid these problems with printk(RAM_DEBUG/RAM_SPEW, ...) instead of using preprocessor dependent printram.
-
Arthur Heymans (Code Review)