Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39589 )
Change subject: soc/amd/picasso: Set I2c clock reference to 150MHz ......................................................................
soc/amd/picasso: Set I2c clock reference to 150MHz
Picasso uses a 150MHz reference clock for the Designware I2c devices. This update allows us to get the correct speeds out.
BUG=b:143885765 TEST=Trembyle has 400kHz I2c clock
Change-Id: Ia888a74e51201b6c911e0e810f0535403204cf60 Signed-off-by: Martin Roth martinroth@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+... --- M src/soc/amd/picasso/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/39589/1
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index acceb00..e193755 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -196,7 +196,7 @@
config DRIVERS_I2C_DESIGNWARE_CLOCK_MHZ int - default 133 + default 150
config PICASSO_LPC_IOMUX bool
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39589 )
Change subject: soc/amd/picasso: Set I2c clock reference to 150MHz ......................................................................
Patch Set 1: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39589 )
Change subject: soc/amd/picasso: Set I2c clock reference to 150MHz ......................................................................
Patch Set 1: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/39589/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39589/1//COMMIT_MSG@9 PS1, Line 9: I2c I2C ?
https://review.coreboot.org/c/coreboot/+/39589/1//COMMIT_MSG@13 PS1, Line 13: I2c I2C ?
https://review.coreboot.org/c/coreboot/+/39589/1//COMMIT_MSG@17 PS1, Line 17: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+... Can shorten this a bit:
https://chromium-review.googlesource.com/1970656
Hello build bot (Jenkins), Paul Menzel, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39589
to look at the new patch set (#2).
Change subject: soc/amd/picasso: Set I2C clock reference to 150MHz ......................................................................
soc/amd/picasso: Set I2C clock reference to 150MHz
Picasso uses a 150MHz reference clock for the Designware I2C devices. This update allows us to get the correct speeds out.
BUG=b:143885765 TEST=Trembyle has 400kHz I2C clock
Change-Id: Ia888a74e51201b6c911e0e810f0535403204cf60 Signed-off-by: Martin Roth martinroth@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1970656 --- M src/soc/amd/picasso/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/39589/2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39589 )
Change subject: soc/amd/picasso: Set I2C clock reference to 150MHz ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39589/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39589/1//COMMIT_MSG@9 PS1, Line 9: I2c
I2C ?
Done
https://review.coreboot.org/c/coreboot/+/39589/1//COMMIT_MSG@13 PS1, Line 13: I2c
I2C ?
Done
https://review.coreboot.org/c/coreboot/+/39589/1//COMMIT_MSG@17 PS1, Line 17: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...
Can shorten this a bit: […]
Done
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39589 )
Change subject: soc/amd/picasso: Set I2C clock reference to 150MHz ......................................................................
soc/amd/picasso: Set I2C clock reference to 150MHz
Picasso uses a 150MHz reference clock for the Designware I2C devices. This update allows us to get the correct speeds out.
BUG=b:143885765 TEST=Trembyle has 400kHz I2C clock
Change-Id: Ia888a74e51201b6c911e0e810f0535403204cf60 Signed-off-by: Martin Roth martinroth@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1970656 Reviewed-on: https://review.coreboot.org/c/coreboot/+/39589 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/soc/amd/picasso/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index acceb00..e193755 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -196,7 +196,7 @@
config DRIVERS_I2C_DESIGNWARE_CLOCK_MHZ int - default 133 + default 150
config PICASSO_LPC_IOMUX bool
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
Paul Menzel (Code Review)