Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49217 )
Change subject: device/Kconfig: Add MAINBOARD_HAS_NATIVE_RK3288_VGA_INIT ......................................................................
device/Kconfig: Add MAINBOARD_HAS_NATIVE_RK3288_VGA_INIT
Change-Id: I06effd234707bd399a10cf5a4cdc8213777639e1 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/device/Kconfig M src/soc/rockchip/rk3288/Kconfig 2 files changed, 8 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/49217/1
diff --git a/src/device/Kconfig b/src/device/Kconfig index baa7110..a176f0a 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -53,6 +53,13 @@ Selected by mainboards / drivers that provide native graphics init for Aspeed GPUs within coreboot.
+config MAINBOARD_HAS_NATIVE_RK3288_VGA_INIT + def_bool n + select MAINBOARD_HAS_NATIVE_VGA_INIT + help + Selected by mainboards / drivers that provide native graphics + init for Rockchip RK3288 GPUs within coreboot. + config MAINBOARD_FORCE_NATIVE_VGA_INIT def_bool n depends on MAINBOARD_HAS_NATIVE_VGA_INIT || MAINBOARD_HAS_LIBGFXINIT diff --git a/src/soc/rockchip/rk3288/Kconfig b/src/soc/rockchip/rk3288/Kconfig index a51df2a..6a97c8a 100644 --- a/src/soc/rockchip/rk3288/Kconfig +++ b/src/soc/rockchip/rk3288/Kconfig @@ -12,7 +12,7 @@ select GENERIC_GPIO_LIB select RTC select UART_OVERRIDE_REFCLK - select MAINBOARD_HAS_NATIVE_VGA_INIT + select MAINBOARD_HAS_NATIVE_RK3288_VGA_INIT select MAINBOARD_FORCE_NATIVE_VGA_INIT select HAVE_LINEAR_FRAMEBUFFER select NO_BOOTBLOCK_CONSOLE
Attention is currently required from: Patrick Rudolph. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49217 )
Change subject: device/Kconfig: Add MAINBOARD_HAS_NATIVE_RK3288_VGA_INIT ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49217/comment/793886e4_1f59cb26 PS1, Line 8: Please explain what you're trying to do. I don't understand why this needs to be a separate option at all, and why it's not defined in the SoC Kconfig instead.
Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/49217?usp=email )
Change subject: device/Kconfig: Add MAINBOARD_HAS_NATIVE_RK3288_VGA_INIT ......................................................................
Abandoned
-
Julius Werner (Code Review) -
Patrick Rudolph (Code Review)
-
Stefan Reinauer (Code Review)