Kyösti Mälkki (kyosti.malkki@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5200
-gerrit
commit c97cc980d42f48ab861ee0cae4d5773503bd9aa0 Author: Kyösti Mälkki kyosti.malkki@gmail.com Date: Wed Feb 12 14:45:02 2014 +0200
PCI: Drop includes under cpu
The files affected do not make any PCI configuration calls. If they did, the more correct includes would be pci_ops.h, pci_defs.h and pci_ids.h.
Change-Id: I3e7f009371be6ea50318eaabf0c15500cb3f1210 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- src/cpu/amd/agesa/family10/model_10_init.c | 1 - src/cpu/amd/agesa/family12/model_12_init.c | 1 - src/cpu/amd/agesa/family14/model_14_init.c | 1 - src/cpu/amd/agesa/family15/model_15_init.c | 1 - src/cpu/amd/agesa/family15tn/model_15_init.c | 1 - src/cpu/amd/agesa/family16kb/model_16_init.c | 1 - src/cpu/amd/agesa/s3_resume.c | 4 ---- src/cpu/amd/geode_gx1/geode_gx1_init.c | 1 - src/cpu/amd/geode_gx2/cpubug.c | 2 -- src/cpu/amd/geode_gx2/geode_gx2_init.c | 1 - src/cpu/amd/geode_lx/geode_lx_init.c | 1 - src/cpu/intel/ep80579/ep80579_init.c | 1 - src/cpu/intel/fsp_model_206ax/acpi.c | 1 - src/cpu/intel/fsp_model_206ax/model_206ax_init.c | 1 - src/cpu/intel/haswell/acpi.c | 1 - src/cpu/intel/haswell/haswell_init.c | 1 - src/cpu/intel/model_1067x/model_1067x_init.c | 1 - src/cpu/intel/model_106cx/model_106cx_init.c | 1 - src/cpu/intel/model_2065x/acpi.c | 1 - src/cpu/intel/model_2065x/model_2065x_init.c | 1 - src/cpu/intel/model_206ax/acpi.c | 1 - src/cpu/intel/model_206ax/model_206ax_init.c | 1 - src/cpu/intel/model_65x/model_65x_init.c | 1 - src/cpu/intel/model_68x/model_68x_init.c | 1 - src/cpu/intel/model_69x/model_69x_init.c | 1 - src/cpu/intel/model_6bx/model_6bx_init.c | 1 - src/cpu/intel/model_6dx/model_6dx_init.c | 1 - src/cpu/intel/model_6ex/model_6ex_init.c | 1 - src/cpu/intel/model_6fx/model_6fx_init.c | 1 - src/cpu/intel/model_6xx/model_6xx_init.c | 1 - src/cpu/intel/model_f0x/model_f0x_init.c | 1 - src/cpu/intel/model_f1x/model_f1x_init.c | 1 - src/cpu/intel/model_f2x/model_f2x_init.c | 1 - src/cpu/intel/model_f3x/model_f3x_init.c | 1 - src/cpu/intel/model_f4x/model_f4x_init.c | 1 - 35 files changed, 39 deletions(-)
diff --git a/src/cpu/amd/agesa/family10/model_10_init.c b/src/cpu/amd/agesa/family10/model_10_init.c index 899a3c4..6fbfd1a 100644 --- a/src/cpu/amd/agesa/family10/model_10_init.c +++ b/src/cpu/amd/agesa/family10/model_10_init.c @@ -21,7 +21,6 @@ #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/x86/msr.h> #include <cpu/x86/pae.h> diff --git a/src/cpu/amd/agesa/family12/model_12_init.c b/src/cpu/amd/agesa/family12/model_12_init.c index 0dae912..635bd81 100644 --- a/src/cpu/amd/agesa/family12/model_12_init.c +++ b/src/cpu/amd/agesa/family12/model_12_init.c @@ -21,7 +21,6 @@ #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/x86/msr.h> #include <cpu/x86/pae.h> diff --git a/src/cpu/amd/agesa/family14/model_14_init.c b/src/cpu/amd/agesa/family14/model_14_init.c index 7ae2b24..1a97f2c 100644 --- a/src/cpu/amd/agesa/family14/model_14_init.c +++ b/src/cpu/amd/agesa/family14/model_14_init.c @@ -21,7 +21,6 @@ #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/x86/msr.h> #include <cpu/x86/pae.h> diff --git a/src/cpu/amd/agesa/family15/model_15_init.c b/src/cpu/amd/agesa/family15/model_15_init.c index ea7e663..a755e1c 100644 --- a/src/cpu/amd/agesa/family15/model_15_init.c +++ b/src/cpu/amd/agesa/family15/model_15_init.c @@ -21,7 +21,6 @@ #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/x86/msr.h> #include <cpu/x86/pae.h> diff --git a/src/cpu/amd/agesa/family15tn/model_15_init.c b/src/cpu/amd/agesa/family15tn/model_15_init.c index aebc27b..f396201 100644 --- a/src/cpu/amd/agesa/family15tn/model_15_init.c +++ b/src/cpu/amd/agesa/family15tn/model_15_init.c @@ -21,7 +21,6 @@ #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/x86/msr.h> #include <cpu/x86/pae.h> diff --git a/src/cpu/amd/agesa/family16kb/model_16_init.c b/src/cpu/amd/agesa/family16kb/model_16_init.c index 2964b78..734d9ef 100644 --- a/src/cpu/amd/agesa/family16kb/model_16_init.c +++ b/src/cpu/amd/agesa/family16kb/model_16_init.c @@ -21,7 +21,6 @@ #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/x86/msr.h> #include <cpu/x86/pae.h> diff --git a/src/cpu/amd/agesa/s3_resume.c b/src/cpu/amd/agesa/s3_resume.c index 558fc75..e056a18 100644 --- a/src/cpu/amd/agesa/s3_resume.c +++ b/src/cpu/amd/agesa/s3_resume.c @@ -26,10 +26,6 @@ #include <cpu/x86/cache.h> #include <cbmem.h> #include <device/device.h> -#include <device/pci.h> -#ifndef __PRE_RAM__ -#include <device/pci_ops.h> -#endif #include <arch/io.h> #include <arch/acpi.h> #include <string.h> diff --git a/src/cpu/amd/geode_gx1/geode_gx1_init.c b/src/cpu/amd/geode_gx1/geode_gx1_init.c index 60f9473..8fbf507 100644 --- a/src/cpu/amd/geode_gx1/geode_gx1_init.c +++ b/src/cpu/amd/geode_gx1/geode_gx1_init.c @@ -1,6 +1,5 @@ #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/cpu.h> #include <cpu/x86/lapic.h> diff --git a/src/cpu/amd/geode_gx2/cpubug.c b/src/cpu/amd/geode_gx2/cpubug.c index eddc924..b6824ad 100644 --- a/src/cpu/amd/geode_gx2/cpubug.c +++ b/src/cpu/amd/geode_gx2/cpubug.c @@ -2,8 +2,6 @@ #include <arch/io.h> #include <stdint.h> #include <device/device.h> -#include <device/pci.h> -#include <device/pci_ids.h> #include <stdlib.h> #include <string.h> #include <cpu/amd/gx2def.h> diff --git a/src/cpu/amd/geode_gx2/geode_gx2_init.c b/src/cpu/amd/geode_gx2/geode_gx2_init.c index 7e481b5..b8f56db 100644 --- a/src/cpu/amd/geode_gx2/geode_gx2_init.c +++ b/src/cpu/amd/geode_gx2/geode_gx2_init.c @@ -1,6 +1,5 @@ #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/cpu.h> #include <cpu/x86/lapic.h> diff --git a/src/cpu/amd/geode_lx/geode_lx_init.c b/src/cpu/amd/geode_lx/geode_lx_init.c index e2eded0..cd931a4 100644 --- a/src/cpu/amd/geode_lx/geode_lx_init.c +++ b/src/cpu/amd/geode_lx/geode_lx_init.c @@ -24,7 +24,6 @@
#include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/cpu.h> #include <cpu/x86/lapic.h> diff --git a/src/cpu/intel/ep80579/ep80579_init.c b/src/cpu/intel/ep80579/ep80579_init.c index 22166b1..433636d 100644 --- a/src/cpu/intel/ep80579/ep80579_init.c +++ b/src/cpu/intel/ep80579/ep80579_init.c @@ -19,7 +19,6 @@
#include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h> diff --git a/src/cpu/intel/fsp_model_206ax/acpi.c b/src/cpu/intel/fsp_model_206ax/acpi.c index 47e651f..d24de06 100644 --- a/src/cpu/intel/fsp_model_206ax/acpi.c +++ b/src/cpu/intel/fsp_model_206ax/acpi.c @@ -29,7 +29,6 @@ #include <cpu/intel/speedstep.h> #include <cpu/intel/turbo.h> #include <device/device.h> -#include <device/pci.h> #include "model_206ax.h" #include "chip.h"
diff --git a/src/cpu/intel/fsp_model_206ax/model_206ax_init.c b/src/cpu/intel/fsp_model_206ax/model_206ax_init.c index c362ae3..5f4d3ce 100644 --- a/src/cpu/intel/fsp_model_206ax/model_206ax_init.c +++ b/src/cpu/intel/fsp_model_206ax/model_206ax_init.c @@ -22,7 +22,6 @@
#include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <arch/acpi.h> #include <cpu/cpu.h> diff --git a/src/cpu/intel/haswell/acpi.c b/src/cpu/intel/haswell/acpi.c index 9e10c75..c67c8a1 100644 --- a/src/cpu/intel/haswell/acpi.c +++ b/src/cpu/intel/haswell/acpi.c @@ -29,7 +29,6 @@ #include <cpu/intel/speedstep.h> #include <cpu/intel/turbo.h> #include <device/device.h> -#include <device/pci.h> #include "haswell.h" #include "chip.h"
diff --git a/src/cpu/intel/haswell/haswell_init.c b/src/cpu/intel/haswell/haswell_init.c index f8d295e..7c9beed 100644 --- a/src/cpu/intel/haswell/haswell_init.c +++ b/src/cpu/intel/haswell/haswell_init.c @@ -22,7 +22,6 @@
#include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <arch/acpi.h> #include <cpu/cpu.h> diff --git a/src/cpu/intel/model_1067x/model_1067x_init.c b/src/cpu/intel/model_1067x/model_1067x_init.c index 2b151a3..4779a51 100644 --- a/src/cpu/intel/model_1067x/model_1067x_init.c +++ b/src/cpu/intel/model_1067x/model_1067x_init.c @@ -22,7 +22,6 @@
#include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h> diff --git a/src/cpu/intel/model_106cx/model_106cx_init.c b/src/cpu/intel/model_106cx/model_106cx_init.c index 0d96172..356b86d 100644 --- a/src/cpu/intel/model_106cx/model_106cx_init.c +++ b/src/cpu/intel/model_106cx/model_106cx_init.c @@ -19,7 +19,6 @@
#include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h> diff --git a/src/cpu/intel/model_2065x/acpi.c b/src/cpu/intel/model_2065x/acpi.c index fa0dc95..49517ac 100644 --- a/src/cpu/intel/model_2065x/acpi.c +++ b/src/cpu/intel/model_2065x/acpi.c @@ -29,7 +29,6 @@ #include <cpu/intel/speedstep.h> #include <cpu/intel/turbo.h> #include <device/device.h> -#include <device/pci.h> #include "model_2065x.h" #include "chip.h"
diff --git a/src/cpu/intel/model_2065x/model_2065x_init.c b/src/cpu/intel/model_2065x/model_2065x_init.c index 6df45a4..2cbe906 100644 --- a/src/cpu/intel/model_2065x/model_2065x_init.c +++ b/src/cpu/intel/model_2065x/model_2065x_init.c @@ -22,7 +22,6 @@
#include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <arch/acpi.h> #include <cpu/cpu.h> diff --git a/src/cpu/intel/model_206ax/acpi.c b/src/cpu/intel/model_206ax/acpi.c index 80ed4ba..f97c1ee 100644 --- a/src/cpu/intel/model_206ax/acpi.c +++ b/src/cpu/intel/model_206ax/acpi.c @@ -29,7 +29,6 @@ #include <cpu/intel/speedstep.h> #include <cpu/intel/turbo.h> #include <device/device.h> -#include <device/pci.h> #include "model_206ax.h" #include "chip.h"
diff --git a/src/cpu/intel/model_206ax/model_206ax_init.c b/src/cpu/intel/model_206ax/model_206ax_init.c index 6028801..26fd721 100644 --- a/src/cpu/intel/model_206ax/model_206ax_init.c +++ b/src/cpu/intel/model_206ax/model_206ax_init.c @@ -22,7 +22,6 @@
#include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <arch/acpi.h> #include <cpu/cpu.h> diff --git a/src/cpu/intel/model_65x/model_65x_init.c b/src/cpu/intel/model_65x/model_65x_init.c index 6914122..a9f1811 100644 --- a/src/cpu/intel/model_65x/model_65x_init.c +++ b/src/cpu/intel/model_65x/model_65x_init.c @@ -20,7 +20,6 @@
#include <stdint.h> #include <device/device.h> -#include <device/pci.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h> #include <cpu/x86/msr.h> diff --git a/src/cpu/intel/model_68x/model_68x_init.c b/src/cpu/intel/model_68x/model_68x_init.c index 4bb9b56..c2f0002 100644 --- a/src/cpu/intel/model_68x/model_68x_init.c +++ b/src/cpu/intel/model_68x/model_68x_init.c @@ -22,7 +22,6 @@
#include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h> diff --git a/src/cpu/intel/model_69x/model_69x_init.c b/src/cpu/intel/model_69x/model_69x_init.c index 9ee7424..4339274 100644 --- a/src/cpu/intel/model_69x/model_69x_init.c +++ b/src/cpu/intel/model_69x/model_69x_init.c @@ -1,6 +1,5 @@ #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h> diff --git a/src/cpu/intel/model_6bx/model_6bx_init.c b/src/cpu/intel/model_6bx/model_6bx_init.c index e06665a..083109c 100644 --- a/src/cpu/intel/model_6bx/model_6bx_init.c +++ b/src/cpu/intel/model_6bx/model_6bx_init.c @@ -22,7 +22,6 @@
#include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h> diff --git a/src/cpu/intel/model_6dx/model_6dx_init.c b/src/cpu/intel/model_6dx/model_6dx_init.c index 06236a3..18c2fa4 100644 --- a/src/cpu/intel/model_6dx/model_6dx_init.c +++ b/src/cpu/intel/model_6dx/model_6dx_init.c @@ -1,6 +1,5 @@ #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h> diff --git a/src/cpu/intel/model_6ex/model_6ex_init.c b/src/cpu/intel/model_6ex/model_6ex_init.c index 4dc642a..30d3f10 100644 --- a/src/cpu/intel/model_6ex/model_6ex_init.c +++ b/src/cpu/intel/model_6ex/model_6ex_init.c @@ -21,7 +21,6 @@
#include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h> diff --git a/src/cpu/intel/model_6fx/model_6fx_init.c b/src/cpu/intel/model_6fx/model_6fx_init.c index 39aa8e9..034dc9c 100644 --- a/src/cpu/intel/model_6fx/model_6fx_init.c +++ b/src/cpu/intel/model_6fx/model_6fx_init.c @@ -21,7 +21,6 @@
#include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h> diff --git a/src/cpu/intel/model_6xx/model_6xx_init.c b/src/cpu/intel/model_6xx/model_6xx_init.c index e81f9ae..9b92dcc 100644 --- a/src/cpu/intel/model_6xx/model_6xx_init.c +++ b/src/cpu/intel/model_6xx/model_6xx_init.c @@ -1,6 +1,5 @@ #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h> diff --git a/src/cpu/intel/model_f0x/model_f0x_init.c b/src/cpu/intel/model_f0x/model_f0x_init.c index 8d81182..ca40515 100644 --- a/src/cpu/intel/model_f0x/model_f0x_init.c +++ b/src/cpu/intel/model_f0x/model_f0x_init.c @@ -1,6 +1,5 @@ #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h> diff --git a/src/cpu/intel/model_f1x/model_f1x_init.c b/src/cpu/intel/model_f1x/model_f1x_init.c index b294c61..dbb5cd0 100644 --- a/src/cpu/intel/model_f1x/model_f1x_init.c +++ b/src/cpu/intel/model_f1x/model_f1x_init.c @@ -1,6 +1,5 @@ #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h> diff --git a/src/cpu/intel/model_f2x/model_f2x_init.c b/src/cpu/intel/model_f2x/model_f2x_init.c index 9e8fbfc..53eb75e 100644 --- a/src/cpu/intel/model_f2x/model_f2x_init.c +++ b/src/cpu/intel/model_f2x/model_f2x_init.c @@ -1,6 +1,5 @@ #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h> diff --git a/src/cpu/intel/model_f3x/model_f3x_init.c b/src/cpu/intel/model_f3x/model_f3x_init.c index 5752347..f8d9ca6 100644 --- a/src/cpu/intel/model_f3x/model_f3x_init.c +++ b/src/cpu/intel/model_f3x/model_f3x_init.c @@ -1,6 +1,5 @@ #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h> diff --git a/src/cpu/intel/model_f4x/model_f4x_init.c b/src/cpu/intel/model_f4x/model_f4x_init.c index 80d7dc8..260b60a 100644 --- a/src/cpu/intel/model_f4x/model_f4x_init.c +++ b/src/cpu/intel/model_f4x/model_f4x_init.c @@ -1,6 +1,5 @@ #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <string.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h>
-
Kyösti Mälkki