[L] Change in coreboot[main]: mb/asrock: Add SPR 1S server board ASRock Rack SPC741D8-2L2T/BCM

[Fabian Meyer (Code Review)]

Attention is currently required from: Angel Pons, Felix Singer, Nico Huber, Paul Menzel.

Fabian Meyer has posted comments on this change by Fabian Meyer. ( https://review.coreboot.org/c/coreboot/+/82203?usp=email )

Change subject: mb/asrock: Add SPR 1S server board ASRock Rack SPC741D8-2L2T/BCM
......................................................................

Patch Set 9:

(5 comments)

Patchset:

PS9:
> Would you be interested in listed as a maintainer for this mainboard? If so, please add an entry to  […]

Due to my contract running out, I will not have access to this board in the future, so there likely wouldn't be a point to that.

PS9:
> I guess we can just merge this without the FSP-header update. One would […]

No, this does not work. 1) Without the correct headers, the board cannot boot. 2) Without the additional changes in CB:80360 (i.e., just setting the include path in menuconfig), coreboot does not compile.

File src/mainboard/asrock/spc741d8/Kconfig:

PS9:
> Missing SPDX license identifier

Done

https://review.coreboot.org/c/coreboot/+/82203/comment/91734fad_097c9e24?usp... :
PS9, Line 37: config DEBUG_SMI
            : 	d
> Is it needed to enable that by default?

No, removed. Note however that this option is also present in every other EagleStream board's Kconfig, likely not needed there as well.

File src/mainboard/asrock/spc741d8/Kconfig.name:

PS9:
> Missing SPDX license identifier

Done