Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Werner Zeh.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74326 )
Change subject: soc/intel: Introduce ioapic_get_sci_pin()
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
Hi Kyösti. […]
Ah, I will adjust the commit message. Seems like soc_write_sci_irq_select() is currently done at device .init -phase. I probably need to add some comment about making sure ioapic_get_sci_pin() does not get called before that.
In theory, we might want to be able to do more complete IOAPIC programming with correct SCI_IRQ already in ramstage, but currently we don't. If that happens, I might want to see soc_write_sci_irq_select() call done earlier.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74326
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I723c207f1dcbba5e6fc0452fe1dbd087fad290ee
Gerrit-Change-Number: 74326
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Mon, 17 Apr 2023 06:41:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment