29 Jun
2018
29 Jun
'18
6:06 a.m.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27281 )
Change subject: sb/intel/common/smihandler: Use new PMBASE API ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/27281/2/src/southbridge/intel/common/smihand... File src/southbridge/intel/common/smihandler.c:
https://review.coreboot.org/#/c/27281/2/src/southbridge/intel/common/smihand... PS2, Line 289: write_pmbase32(PM1_CNT, read_pmbase32(PM1_CNT) &~SCI_EN); need consistent spacing around '&' (ctx:WxO)
--
To view, visit https://review.coreboot.org/27281
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c64233ecdb8c1e28b319d84149f34bc8f1e4b97
Gerrit-Change-Number: 27281
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 29 Jun 2018 09:06:00 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
2487
days inactive
2487
days old
0 comments
1 participants
participants (1)
-
build bot (Jenkins) (Code Review)