Attention is currently required from: Selma Bensaid, Subrata Banik, Bernardo Perez Priego, Usha P, Andrey Petrov, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51105 )
Change subject: drivers/intel/fsp2_0/memory_init: Add saving memory info API ......................................................................
Patch Set 1:
(1 comment)
File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/c/coreboot/+/51105/comment/b093f2a4_0cd616ef PS1, Line 40: #define FSP_SMBIOS_MEMORY_INFO_GUID \ : { \ : 0xd4, 0x71, 0x20, 0x9b, 0x54, 0xb0, 0x0c, 0x4e, \ : 0x8d, 0x09, 0x11, 0xcf, 0x8b, 0x9f, 0x03, 0x23 \ : } This is a platform specific HOB. It is not defined in PI spec or FSP spec. Instead it is defined as part of FSP platform integration guide. Even though the GUID might be same for the Intel platforms you updated in this CL, it does not belong in this common driver file. One example: AMD Picasso also uses this driver, but it does not make use of this GUID. Similarly, other Intel platforms like GLK, ADL, etc. use this driver but the GUID value is very different.
Same is true for the macros defined above and the HOB structure you are assuming in `save_dimm_info` below.