[S] Change in coreboot[master]: drivers/fsp2: Don't die if the FSP signature doesn't match
Attention is currently required from: Jason Glenesk, Subrata Banik, Andrey Petrov, Fred Reitberger, Felix Held.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69412 )
Change subject: drivers/fsp2: Don't die if the FSP signature doesn't match ......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
IMO, this is living with a bug that existed in FSP. […]
coreboot should not (and honestly cannot) be responsible for issues inside the FSP.
If the FSP cannot run, it should be responsible for doing the check instead of pushing the responsibility to coreboot. We don't do a check for the payload "Oh, this payload is running on a platform it wasn't compiled for" and coreboot shouldn't be responsible for the FSP either.
File src/drivers/intel/fsp2_0/util.c:
https://review.coreboot.org/c/coreboot/+/69412/comment/d13ba12c_cd8c5ee4 PS3, Line 177: If it doesn't match, the : FSP binaries in CBFS are for a different platform than the platform code trying to use it
IMO, it would allow some mismatch, for example: I can now stitch and call into ADL-FSP binaries for […]
Sorry, I think I'm missing your point here. How is this coreboot's responsibility?
-
Martin L Roth (Code Review)