Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28101 )
Change subject: Makefile: Write .xcompile to $(obj) ......................................................................
Patch Set 6:
(6 comments)
.xcompile is also in the .gitignore file and could be removed from there.
https://review.coreboot.org/c/coreboot/+/28101/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/28101/6//COMMIT_MSG@21 PS6, Line 21: a an
https://review.coreboot.org/c/coreboot/+/28101/6/Makefile File Makefile:
https://review.coreboot.org/c/coreboot/+/28101/6/Makefile@467 PS6, Line 467: .xcompile Remove this one?
https://review.coreboot.org/c/coreboot/+/28101/6/src/soc/nvidia/tegra124/lp0... File src/soc/nvidia/tegra124/lp0/Makefile:
https://review.coreboot.org/c/coreboot/+/28101/6/src/soc/nvidia/tegra124/lp0... PS6, Line 16: xcompile Maybe instead of looking for it, just regenerate it here and use it from here? That way we don't have to know what the coreboot build directory is.
https://review.coreboot.org/c/coreboot/+/28101/6/util/abuild/abuild File util/abuild/abuild:
https://review.coreboot.org/c/coreboot/+/28101/6/util/abuild/abuild@471 PS6, Line 471: include $(xcompile) Doesn't this variable need to be defined in abuild? What if abuild is just run from the command line instead of from "what-jenkins-does?"
https://review.coreboot.org/c/coreboot/+/28101/6/util/abuild/abuild@476 PS6, Line 476: .DEFAULT_GOAL := missing_arches Should this go in the other abuild commit?
https://review.coreboot.org/c/coreboot/+/28101/6/util/testing/Makefile.inc File util/testing/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/28101/6/util/testing/Makefile.inc@9... PS6, Line 94: If the nvidia makefiles create .xcompile on their own, this is not needed.
-
Martin Roth (Code Review)