Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Meera Ravindranath, Patrick Rudolph, EricR Lai.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61295 )
Change subject: soc/intel/adl: Update devicetree based on remapping for TBT PCIe
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/alderlake/pcie_rp.c:
https://review.coreboot.org/c/coreboot/+/61295/comment/f77f78e4_55889942
PS3, Line 64: static const struct pcie_rp_group tbt_rp_groups[] = {
can I suggest one improvement if you can […]
Ack
This is really good Subrata..Let me update the patch with the suggestions.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61295
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied16191d6af41f8e2b31baee80cb475e7d557010
Gerrit-Change-Number: 61295
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 24 Jan 2022 05:10:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment