Attention is currently required from: Dinesh Gehlot, Eric Lai, Gareth Yu, Jayvik Desai, Kapil Porwal, Lawrence Chang, Nick Vaccaro, Paul Menzel, SH Kim, Simon Yang, Subrata Banik.
Gareth Yu has posted comments on this change by Lawrence Chang. ( https://review.coreboot.org/c/coreboot/+/86838?usp=email )
Change subject: mb/google/brya/var/meliks: reset DPHY_CLOCK_LANE_TIMING
......................................................................
Patch Set 18:
(1 comment)
File src/mainboard/google/brya/variants/meliks/ramstage.c:
https://review.coreboot.org/c/coreboot/+/86838/comment/859ebf33_3ea5fe76?usp... :
PS17, Line 20: 0xf
Unfortunately, ```mainboard_silicon_init_params``` is too early to use igd bar. […]
Yes, hardcoding the MMIO address is possible. The reason is we need to clear the same system memory which is used by GFX before warm boot. However, I have found 2 possible addresses are used for TWL, 0x81000000 or 0xAF000000. It means that the address can be changed according to different PCI devices. Even only for this project, I can't say the PCI devices are consistent until its EOL. Thought?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86838?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7857c4f71fc7d1d0c5069a462bdd70c8dbb78179
Gerrit-Change-Number: 86838
Gerrit-PatchSet: 18
Gerrit-Owner: Lawrence Chang
lawrence.chang@intel.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Gareth Yu
gareth.yu@intel.corp-partner.google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lawrence Chang
lawrence.chang@intel.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Simon Yang
simon1.yang@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Gareth Yu
gareth.yu@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Gareth Yu
gareth.yu@intel.corp-partner.google.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Lawrence Chang
lawrence.chang@intel.corp-partner.google.com
Gerrit-Comment-Date: Fri, 28 Mar 2025 12:15:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Gareth Yu
gareth.yu@intel.com