Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46018 )
Change subject: soc/intel/*: conversion from constant to Kconfig for XTAL frequency ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46018/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46018/8//COMMIT_MSG@7 PS8, Line 7: soc/intel/*: conversion from constant to Kconfig for XTAL frequency Please add a verb (in imperative mood) to make it a statement:
Convert XTAL frequency constant to Kconfig option
https://review.coreboot.org/c/coreboot/+/46018/8//COMMIT_MSG@9 PS8, Line 9: This converts the constant for the XTAL frequency to a Kconfig option. [Motivation missing]
… because device configuration goes either in Kconfig or devicetree.
(Or should device be able to override it?)