Attention is currently required from: Arec, Chen Wisley, Paul Menzel, Tim Wawrzynczak, Sugnan Prabhu S.
Arec Kao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64415 )
Change subject: mb/google/brya/var/redrix: Configure camera EEPROM power always on
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/64415/comment/01adc07b_daeca613
PS1, Line 9: Remove EEPROM power source interconnect with camera power on/off and keep it
: always on.
Please use 72 characters per line.
Done
https://review.coreboot.org/c/coreboot/+/64415/comment/4f502e0b_ca07b44f
PS1, Line 11:
Why?
It has a small probability to access EEPROM failed when perform a stress test on switching camera on/off.
File src/mainboard/google/brya/variants/redrix/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/64415/comment/264e7caa_14774dd5
PS1, Line 332: 5
Have you instead just tried increasing the delay here after the NVM power was enabled?
No, It seems to me the delay is not a proper solution, even so, it still has little chance to hit read/write EEPROM failed issue with NVM delay time.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64415
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9efab9bb65632a73c1c2635729c38a2aa14c69b2
Gerrit-Change-Number: 64415
Gerrit-PatchSet: 2
Gerrit-Owner: Arec
arec.kao@intel.com
Gerrit-Reviewer: Andy Yeh
andy.yeh@intel.com
Gerrit-Reviewer: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andy Yeh
andy.yeh@intel.com
Gerrit-CC: Arec Kao
arec.kao@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arec
arec.kao@intel.com
Gerrit-Attention: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Comment-Date: Mon, 23 May 2022 06:55:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment