Change in coreboot[master]: mb/google/guybrush/var/dewatt: add specific SPD hex for dewatt - coreboot-gerrit

28 Mar 2022


      Attention is currently required from: Chris Wang, Felix Held.
Robert Zieba has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63132 )
Change subject: mb/google/guybrush/var/dewatt: add specific SPD hex for dewatt
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/guybrush/variants/dewatt/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/63132/comment/0a45da97_be58d06f 
PS4, Line 16: SPD_SOURCES += $(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/memory/K4U6E3S4AB-MGCL.hex     # ID = 9(0b1001)  Parts = K4U6E3S4AB-MGCL
Is there no way to update the memory_parts.json file to get the same effect? I'm concerned about this breaking if this ever gets overwritten by spd_tools.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63132
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia54726ce8c1bae46dcd4fed3df509ef184914e94
Gerrit-Change-Number: 63132
Gerrit-PatchSet: 4
Gerrit-Owner: Chris Wang chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Robert Zieba robertzieba@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Chris Wang chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 28 Mar 2022 14:37:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment