Attention is currently required from: Bora Guvendik, Kapil Porwal, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75555?usp=email )
Change subject: mb/google/rex: Update GPIO PAD IO Standby State ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/rex/variants/rex0/gpio.c:
https://review.coreboot.org/c/coreboot/+/75555/comment/d41dfbce_63690b06 : PS3, Line 19: PAD_CFG_NF_IOSSTATE(GPP_A00, UP_20K, DEEP, NF1, IGNORE),
It was not #1, it was being programmed as NF1.
FSP was modifying the IO Standby State to PAD_CFG1_IOSSTATE_IGNORE before FSP started skipping GpioConfigureIoStandbyState. Now that we are skipping in FSP, coreboot is setting IO Standby State to PAD_CFG1_IOSSTATE_TxLASTRxE, and seems this caused the keyboard / Type-C issues.
"wondering why can't we configure as below or even adding LOCK" PAD_CFG_NF sets PAD_CFG1_IOSSTATE_TxLASTRxE, instead of what we need which is PAD_CFG1_IOSSTATE_IGNORE
understood then we need to add the same changes to add different rex variants.