Attention is currently required from: Furquan Shaikh, Frans Hendriks, Patrick Rudolph, Aaron Durbin, Wim Vervoorn.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50350 )
Change subject: spd_bin: Replace get_spd_cbfs_rdev() with spd_cbfs_map()
......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/cannonlake/cnl_memcfg_init.c:
https://review.coreboot.org/c/coreboot/+/50350/comment/692438d5_66390cdd
PS1, Line 92: if (!spd_data_ptr);
trailing semicolon indicates no statements, indent implies otherwise
https://review.coreboot.org/c/coreboot/+/50350/comment/449a6e33_565dfd74
PS1, Line 92: if (!spd_data_ptr);
trailing statements should be on next line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50350
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec7571bec809f2f0712e7a97b4c853b8b40702d1
Gerrit-Change-Number: 50350
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Attention: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Comment-Date: Sat, 06 Feb 2021 02:57:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment