Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35403 )
Change subject: soc/intel/common/basecode: Implement CSE update flow ......................................................................
Patch Set 35:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35403/19/src/soc/intel/common/basec... File src/soc/intel/common/basecode/fw_update/cse_update.c:
https://review.coreboot.org/c/coreboot/+/35403/19/src/soc/intel/common/basec... PS19, Line 120: /* If CSE boots from BP1, then CSE ready for HMRFPO mode, but not in HMRFPO mode */
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35403/19/src/soc/intel/common/basec... PS19, Line 121: if(current_bp != BP1) {
space required before the open parenthesis '('
Done
-
Sridhar Siricilla (Code Review)