Change in ...coreboot[master]: vboot: rename BOOT_OPROM_NEEDED

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Joel Kitching (Code Review)

9 May 2019 9 May '19

9:36 p.m.

Joel Kitching has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32720

Change subject: vboot: rename BOOT_OPROM_NEEDED ......................................................................

vboot: rename BOOT_OPROM_NEEDED

Verified Boot OPROM code is being refactored. OPROM is being generalized into "display initialization". As such, the NVRAM request flag is being renamed from OPROM_NEEDED to DISPLAY_REQUEST.

BUG=b:124141368, b:124192753, chromium:948529 TEST=make clean && make test-abuild BRANCH=none

Change-Id: I74374abf7d1deb594c073f7a4a76c9de46092143 Signed-off-by: Joel Kitching kitching@google.com Cq-Depend: chromium:1605640 --- M src/security/vboot/vbnv.c M src/security/vboot/vbnv_layout.h 2 files changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/32720/1

diff --git a/src/security/vboot/vbnv.c b/src/security/vboot/vbnv.c index b999418..2449328 100644 --- a/src/security/vboot/vbnv.c +++ b/src/security/vboot/vbnv.c @@ -140,11 +140,11 @@ return vbnv_data(RECOVERY_OFFSET); }

-/* Read the BOOT_OPROM_NEEDED flag from VBNV. */ +/* Read the BOOT_DISPLAY_REQUEST flag from VBNV. */ int vboot_wants_oprom(void) { vbnv_setup(); - return (vbnv_data(BOOT_OFFSET) & BOOT_OPROM_NEEDED) ? 1 : 0; + return (vbnv_data(BOOT_OFFSET) & BOOT_DIPLAY_REQUEST) ? 1 : 0; }

/* Read the USB Device Controller(UDC) enable flag from VBNV. */ diff --git a/src/security/vboot/vbnv_layout.h b/src/security/vboot/vbnv_layout.h index a9326e4..a3c2490 100644 --- a/src/security/vboot/vbnv_layout.h +++ b/src/security/vboot/vbnv_layout.h @@ -31,7 +31,7 @@ #define BOOT_OFFSET 1 #define BOOT_DEBUG_RESET_MODE 0x80 #define BOOT_DISABLE_DEV_REQUEST 0x40 -#define BOOT_OPROM_NEEDED 0x20 +#define BOOT_DISPLAY_REQUEST 0x20 #define BOOT_TRY_B_COUNT_MASK 0x0F

#define RECOVERY_OFFSET 2

Attachments:

attachment.htm (text/html — 3.8 KB)

Show replies by date

build bot (Jenkins) (Code Review)

9 May 9 May

9:36 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32720 )

Change subject: vboot: rename BOOT_OPROM_NEEDED ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32720/1/src/security/vboot/vbnv.c File src/security/vboot/vbnv.c:

https://review.coreboot.org/#/c/32720/1/src/security/vboot/vbnv.c@147 PS1, Line 147: return (vbnv_data(BOOT_OFFSET) & BOOT_DIPLAY_REQUEST) ? 1 : 0; 'DIPLAY' may be misspelled - perhaps 'DISPLAY'?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32720 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74374abf7d1deb594c073f7a4a76c9de46092143 Gerrit-Change-Number: 32720 Gerrit-PatchSet: 1 Gerrit-Owner: Joel Kitching kitching@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 10 May 2019 04:36:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Joel Kitching (Code Review)

9:36 p.m.

Hello Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32720

to look at the new patch set (#2).

Change subject: vboot: rename BOOT_OPROM_NEEDED ......................................................................

vboot: rename BOOT_OPROM_NEEDED

Verified Boot OPROM code is being refactored. OPROM is being generalized into "display initialization". As such, the NVRAM request flag is being renamed from OPROM_NEEDED to DISPLAY_REQUEST.

BUG=b:124141368, b:124192753, chromium:948529 TEST=make clean && make test-abuild BRANCH=none

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/32720/2

Furquan Shaikh (Code Review)

10:52 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32720 )

Change subject: vboot: rename BOOT_OPROM_NEEDED ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32720 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74374abf7d1deb594c073f7a4a76c9de46092143 Gerrit-Change-Number: 32720 Gerrit-PatchSet: 2 Gerrit-Owner: Joel Kitching kitching@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 10 May 2019 05:52:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

10 May 10 May

5:09 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32720 )

Change subject: vboot: rename BOOT_OPROM_NEEDED ......................................................................

Patch Set 2: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/32720/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32720/2//COMMIT_MSG@7 PS2, Line 7: vboot: rename BOOT_OPROM_NEEDED … to DISPLAY_REQUEST

-- To view, visit https://review.coreboot.org/c/coreboot/+/32720 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74374abf7d1deb594c073f7a4a76c9de46092143 Gerrit-Change-Number: 32720 Gerrit-PatchSet: 2 Gerrit-Owner: Joel Kitching kitching@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 10 May 2019 12:09:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Julius Werner (Code Review)

5:29 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32720 )

Change subject: vboot: rename BOOT_OPROM_NEEDED ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32720 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74374abf7d1deb594c073f7a4a76c9de46092143 Gerrit-Change-Number: 32720 Gerrit-PatchSet: 2 Gerrit-Owner: Joel Kitching kitching@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 11 May 2019 00:29:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Joel Kitching (Code Review)

14 May 14 May

2:52 a.m.

New subject: Change in ...coreboot[master]: vboot: rename BOOT_OPROM_NEEDED to BOOT_DISPLAY_REQUEST

Hello Aaron Durbin, Julius Werner, Paul Menzel, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32720

to look at the new patch set (#3).

Change subject: vboot: rename BOOT_OPROM_NEEDED to BOOT_DISPLAY_REQUEST ......................................................................

vboot: rename BOOT_OPROM_NEEDED to BOOT_DISPLAY_REQUEST

Verified Boot OPROM code is being refactored. OPROM is being generalized into "display initialization". As such, the NVRAM request flag is being renamed from OPROM_NEEDED to DISPLAY_REQUEST.

BUG=b:124141368, b:124192753, chromium:948529 TEST=make clean && make test-abuild BRANCH=none

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/32720/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/32720 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74374abf7d1deb594c073f7a4a76c9de46092143 Gerrit-Change-Number: 32720 Gerrit-PatchSet: 3 Gerrit-Owner: Joel Kitching kitching@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Joel Kitching (Code Review)

2:52 a.m.

New subject: Change in ...coreboot[master]: vboot: rename BOOT_OPROM_NEEDED to BOOT_DISPLAY_REQUEST

Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32720 )

Change subject: vboot: rename BOOT_OPROM_NEEDED to BOOT_DISPLAY_REQUEST ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/32720/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32720/2//COMMIT_MSG@7 PS2, Line 7: vboot: rename BOOT_OPROM_NEEDED

...

… to DISPLAY_REQUEST

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/32720 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74374abf7d1deb594c073f7a4a76c9de46092143 Gerrit-Change-Number: 32720 Gerrit-PatchSet: 3 Gerrit-Owner: Joel Kitching kitching@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 14 May 2019 09:52:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Patrick Georgi (Code Review)

15 May 15 May

10:49 a.m.

New subject: Change in ...coreboot[master]: vboot: rename BOOT_OPROM_NEEDED to BOOT_DISPLAY_REQUEST

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32720 )

Change subject: vboot: rename BOOT_OPROM_NEEDED to BOOT_DISPLAY_REQUEST ......................................................................

vboot: rename BOOT_OPROM_NEEDED to BOOT_DISPLAY_REQUEST

Verified Boot OPROM code is being refactored. OPROM is being generalized into "display initialization". As such, the NVRAM request flag is being renamed from OPROM_NEEDED to DISPLAY_REQUEST.

BUG=b:124141368, b:124192753, chromium:948529 TEST=make clean && make test-abuild BRANCH=none

Change-Id: I74374abf7d1deb594c073f7a4a76c9de46092143 Signed-off-by: Joel Kitching kitching@google.com Cq-Depend: chromium:1605640 Reviewed-on: https://review.coreboot.org/c/coreboot/+/32720 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Julius Werner jwerner@chromium.org --- M src/security/vboot/vbnv.c M src/security/vboot/vbnv_layout.h 2 files changed, 3 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Furquan Shaikh: Looks good to me, approved Julius Werner: Looks good to me, approved

diff --git a/src/security/vboot/vbnv.c b/src/security/vboot/vbnv.c index b999418..78502f7 100644 --- a/src/security/vboot/vbnv.c +++ b/src/security/vboot/vbnv.c @@ -140,11 +140,11 @@ return vbnv_data(RECOVERY_OFFSET); }

#define RECOVERY_OFFSET 2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32720 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74374abf7d1deb594c073f7a4a76c9de46092143 Gerrit-Change-Number: 32720 Gerrit-PatchSet: 4 Gerrit-Owner: Joel Kitching kitching@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

2012

days inactive

2017

days old

coreboot-gerrit@coreboot.org

8 comments

6 participants

tags (0)

participants (6)

build bot (Jenkins) (Code Review)
Furquan Shaikh (Code Review)
Joel Kitching (Code Review)
Julius Werner (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)