Attention is currently required from: Dinesh Gehlot, Eric Lai, Gareth Yu, Jayvik Desai, Kapil Porwal, Lawrence Chang, Nick Vaccaro, Paul Menzel, SH Kim, Simon Yang, Subrata Banik.
Gareth Yu has posted comments on this change by Lawrence Chang. ( https://review.coreboot.org/c/coreboot/+/86838?usp=email )
Change subject: mb/google/brya/var/meliks: reset DPHY_CLOCK_LANE_TIMING
......................................................................
Patch Set 23:
(2 comments)
File src/mainboard/google/brya/variants/meliks/ramstage.c:
https://review.coreboot.org/c/coreboot/+/86838/comment/34b0bf25_7d8d98be?usp... :
PS19, Line 36: if (!igd_base)
`that open brace { should be on the previous line`
Please fix.
File src/mainboard/google/brya/variants/meliks/ramstage.c:
https://review.coreboot.org/c/coreboot/+/86838/comment/ff47c9a9_de66c424?usp... :
PS21, Line 55: the function consistent relies on software forcing the DPHY CLK timing to
`trailing whitespace`
Please fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86838?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7857c4f71fc7d1d0c5069a462bdd70c8dbb78179
Gerrit-Change-Number: 86838
Gerrit-PatchSet: 23
Gerrit-Owner: Lawrence Chang
lawrence.chang@intel.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Gareth Yu
gareth.yu@intel.com
Gerrit-Reviewer: Gareth Yu
gareth.yu@intel.corp-partner.google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lawrence Chang
lawrence.chang@intel.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Simon Yang
simon1.yang@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Gareth Yu
gareth.yu@intel.corp-partner.google.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Lawrence Chang
lawrence.chang@intel.corp-partner.google.com
Gerrit-Comment-Date: Mon, 31 Mar 2025 05:07:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No