Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60751 )
Change subject: src/mainboard/starlabs: Remove unused <option.h> ......................................................................
src/mainboard/starlabs: Remove unused <option.h>
Found using: diff <(git grep -l '#include <option.h>' -- src/) <(git grep -l 'sanitize_cmos(|get_uint_option(|set_uint_option(|get_uint_option(|set_uint_option' -- src/) |grep "<"
Change-Id: Ib79dfa73b8a30ae1b1e432318bd42e4e3d845af3 Signed-off-by: Elyes Haouas ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/60751 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Sean Rhodes sean@starlabs.systems Reviewed-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/starlabs/labtop/smbios.c M src/mainboard/starlabs/lite/mainboard.c M src/mainboard/starlabs/lite/smbios.c 3 files changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Sean Rhodes: Looks good to me, approved
diff --git a/src/mainboard/starlabs/labtop/smbios.c b/src/mainboard/starlabs/labtop/smbios.c index b787986..22f3ad3 100644 --- a/src/mainboard/starlabs/labtop/smbios.c +++ b/src/mainboard/starlabs/labtop/smbios.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <device/pci_def.h> #include <ec/starlabs/merlin/ec.h> -#include <option.h> #include <smbios.h> #include <types.h> #include <uuid.h> diff --git a/src/mainboard/starlabs/lite/mainboard.c b/src/mainboard/starlabs/lite/mainboard.c index 60e65ee..0453709 100644 --- a/src/mainboard/starlabs/lite/mainboard.c +++ b/src/mainboard/starlabs/lite/mainboard.c @@ -2,7 +2,6 @@
#include <device/device.h> #include <soc/ramstage.h> -#include <option.h> #include <variants.h>
static void init_mainboard(void *chip_info) diff --git a/src/mainboard/starlabs/lite/smbios.c b/src/mainboard/starlabs/lite/smbios.c index 7894ebb..3eaaf3a 100644 --- a/src/mainboard/starlabs/lite/smbios.c +++ b/src/mainboard/starlabs/lite/smbios.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <device/pci_def.h> #include <ec/starlabs/merlin/ec.h> -#include <option.h> #include <smbios.h> #include <types.h> #include <uuid.h>
-
Felix Singer (Code Review)