Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59258 )
Change subject: drivers/intel/gma: Remove _BCL from acpigen ......................................................................
drivers/intel/gma: Remove _BCL from acpigen
As `INTEL_GMA_ACPI` is selected by default for most Intel SOC's, but if the brightness control isn't Intels (i.e. `drivers/intel/gma/acpi/default_brightness_levels.asl` isn't included, there wont be a hook for BCL.
This results in:
``` No Local Variables are initialized for Method [_BCL] No Arguments are initialized for method [_BCL] ```
Signed-off-by: Sean Rhodes sean@starlabs.systems Change-Id: Icf2f2fa33abd11952c888c9502d1d5ef1ad6544f --- M src/drivers/intel/gma/acpi.c 1 file changed, 0 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/59258/1
diff --git a/src/drivers/intel/gma/acpi.c b/src/drivers/intel/gma/acpi.c index 4a89bb9..5f41079 100644 --- a/src/drivers/intel/gma/acpi.c +++ b/src/drivers/intel/gma/acpi.c @@ -59,17 +59,6 @@ /* ACPI brightness for LCD. */ if (kind == 4) { /* - Method (_BCL, 0, NotSerialized) - { - Return (^^XBCL()) - } - */ - acpigen_write_method("_BCL", 0); - acpigen_emit_byte(RETURN_OP); - acpigen_emit_namestring("^^XBCL"); - acpigen_pop_len(); - - /* Method (_BCM, 1, NotSerialized) { ^^XBCM(Arg0)