Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84931?usp=email )
Change subject: mb/google/rauru: Enable ChromeOS EC
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/rauru/bootblock.c:
https://review.coreboot.org/c/coreboot/+/84931/comment/e53ab4c0_0cb2447a?usp... :
PS2, Line 20: mtk_spi_init(CONFIG_EC_GOOGLE_CHROMEEC_SPI_BUS, SPI_PAD0_MASK, 3 * MHz, 0);
I’d be great if you mentioned the datasheet in the commit message, where it’s specified, that it ope […]
This function call simply indicates that the AP's SPI speed is set to 3MHz on the SPI bus that connects to the ChromeOS EC.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84931?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I20828eee93975e75dfb777fe29d5e1c3454b5059
Gerrit-Change-Number: 84931
Gerrit-PatchSet: 4
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Yidi Lin
yidilin@google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Fri, 01 Nov 2024 14:17:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org