Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36593 )
Change subject: cpu/ti/am335x: Extend monotonic timer to early stages ......................................................................
cpu/ti/am335x: Extend monotonic timer to early stages
Change-Id: Ifb3f624930c9ef663fae30cd5ddcb1d3d46f06b1 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/cpu/ti/am335x/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/36593/1
diff --git a/src/cpu/ti/am335x/Makefile.inc b/src/cpu/ti/am335x/Makefile.inc index 24a79dd..404848a 100644 --- a/src/cpu/ti/am335x/Makefile.inc +++ b/src/cpu/ti/am335x/Makefile.inc @@ -3,9 +3,11 @@ bootblock-y += dmtimer.c bootblock-y += gpio.c bootblock-y += pinmux.c +bootblock-y += monotonic_timer.c
romstage-y += nand.c romstage-y += cbmem.c +romstage-y += monotonic_timer.c
ramstage-y += dmtimer.c ramstage-y += monotonic_timer.c
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36593 )
Change subject: cpu/ti/am335x: Extend monotonic timer to early stages ......................................................................
Patch Set 1:
Missing timer_monotonic_get() breaks CB:36574. I understand this is not really a platform that works though, nor do I plan to make it work.
Hello Aaron Durbin, Julius Werner, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36593
to look at the new patch set (#2).
Change subject: cpu/ti/am335x: Extend monotonic timer to early stages ......................................................................
cpu/ti/am335x: Extend monotonic timer to early stages
It is actually all completely broken, dmtimer.c is not really implemented.
Change-Id: Ifb3f624930c9ef663fae30cd5ddcb1d3d46f06b1 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/cpu/ti/am335x/Makefile.inc 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/36593/2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36593 )
Change subject: cpu/ti/am335x: Extend monotonic timer to early stages ......................................................................
Patch Set 2: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36593 )
Change subject: cpu/ti/am335x: Extend monotonic timer to early stages ......................................................................
cpu/ti/am335x: Extend monotonic timer to early stages
It is actually all completely broken, dmtimer.c is not really implemented.
Change-Id: Ifb3f624930c9ef663fae30cd5ddcb1d3d46f06b1 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36593 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/cpu/ti/am335x/Makefile.inc 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved
diff --git a/src/cpu/ti/am335x/Makefile.inc b/src/cpu/ti/am335x/Makefile.inc index d3ef970..e1a3b9c 100644 --- a/src/cpu/ti/am335x/Makefile.inc +++ b/src/cpu/ti/am335x/Makefile.inc @@ -3,9 +3,12 @@ bootblock-y += dmtimer.c bootblock-y += gpio.c bootblock-y += pinmux.c +bootblock-y += monotonic_timer.c
romstage-y += nand.c romstage-y += cbmem.c +romstage-y += dmtimer.c +romstage-y += monotonic_timer.c
ramstage-y += dmtimer.c ramstage-y += monotonic_timer.c
-
Aaron Durbin (Code Review) -
Kyösti Mälkki (Code Review)