Change in coreboot[master]: mb/asus/a88xm-e: Disable SeaBIOS options unsupported by hardware

[Mike Banon (Code Review)]

Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39898 )

Change subject: mb/asus/a88xm-e: Disable SeaBIOS options unsupported by hardware
......................................................................

mb/asus/a88xm-e: Disable SeaBIOS options unsupported by hardware

A88XM-E does not have any SAS or NVMe controllers, so it makes sense
to disable the related SeaBIOS options for this board. This
reduces the size of compiled SeaBIOS by 129344-124096 = 5248 bytes.

Signed-off-by: Mike Banon 
Change-Id: I6502a0251ee61fae24573ba4802d3d2e99ed498f
---
M src/mainboard/asus/a88xm-e/Kconfig
A src/mainboard/asus/a88xm-e/config_seabios
2 files changed, 10 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/39898/1

diff --git a/src/mainboard/asus/a88xm-e/Kconfig b/src/mainboard/asus/a88xm-e/Kconfig
index e362066..6e3a0d8 100644
--- a/src/mainboard/asus/a88xm-e/Kconfig
+++ b/src/mainboard/asus/a88xm-e/Kconfig
@@ -102,4 +102,8 @@
    bool
    default n

+config PAYLOAD_CONFIGFILE
+	string
+	default "$(top)/src/mainboard/$(MAINBOARDDIR)/config_seabios" if PAYLOAD_SEABIOS
+
 endif # BOARD_ASUS_A88XM_E
diff --git a/src/mainboard/asus/a88xm-e/config_seabios b/src/mainboard/asus/a88xm-e/config_seabios
new file mode 100644
index 0000000..e4ebd66
--- /dev/null
+++ b/src/mainboard/asus/a88xm-e/config_seabios
@@ -0,0 +1,6 @@
+###
+### SeaBIOS custom configuration for ASUS A88XM-E
+###
+# CONFIG_MEGASAS is not set
+# CONFIG_NVME is not set
+#

[Jonathan Kollasch (Code Review)]

Jonathan Kollasch has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39898 )

Change subject: mb/asus/a88xm-e: Disable SeaBIOS options unsupported by hardware
......................................................................

Patch Set 1: Code-Review-1

The board has PCIe slots, so it would be possible to install a NVMe or SAS controller.  SAS cards will often have option ROMs, but NVMe cards (to my knowledge) usually don't, so I'd say NVMe support at least should be retained.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39898 )

Change subject: mb/asus/a88xm-e: Disable SeaBIOS options unsupported by hardware
......................................................................

Patch Set 1: Code-Review-1

I don't think anybody who needs these extra 5 KiB will be using the default configuration.

[Mike Banon (Code Review)]

Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39898 )

Change subject: mb/asus/a88xm-e: Disable SeaBIOS options unsupported by hardware
......................................................................

Abandoned