Change in ...coreboot[master]: src/mainboard/asus/am1i-a: Disable SeaBIOS options not supported by h...
Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33871
Change subject: src/mainboard/asus/am1i-a: Disable SeaBIOS options not supported by hardware ......................................................................
src/mainboard/asus/am1i-a: Disable SeaBIOS options not supported by hardware
AM1I-A does not have any SAS or NVMe controllers, so it makes sense to disable the related SeaBIOS options for this motherboard. This reduces the size of compiled SeaBIOS by 129344-124096 = 5248 bytes.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I5ddf695f4f349697d08a685fa04c90d3afd723c5 --- M src/mainboard/asus/am1i-a/Kconfig A src/mainboard/asus/am1i-a/config_seabios 2 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33871/1
diff --git a/src/mainboard/asus/am1i-a/Kconfig b/src/mainboard/asus/am1i-a/Kconfig index d50edbe..6d88992 100644 --- a/src/mainboard/asus/am1i-a/Kconfig +++ b/src/mainboard/asus/am1i-a/Kconfig @@ -54,4 +54,8 @@ bool default n
+config PAYLOAD_CONFIGFILE + string + default "$(top)/src/mainboard/$(MAINBOARDDIR)/config_seabios" if PAYLOAD_SEABIOS + endif # BOARD_ASUS_AM1I_A diff --git a/src/mainboard/asus/am1i-a/config_seabios b/src/mainboard/asus/am1i-a/config_seabios new file mode 100644 index 0000000..0ee9cea --- /dev/null +++ b/src/mainboard/asus/am1i-a/config_seabios @@ -0,0 +1,6 @@ +### +### SeaBIOS custom configuration for ASUS AM1I-A +### +# CONFIG_MEGASAS is not set +# CONFIG_NVME is not set +#
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33871 )
Change subject: src/mainboard/asus/am1i-a: Disable SeaBIOS options not supported by hardware ......................................................................
Patch Set 1:
Similar to CB:33870, except that in this case "CONFIG_TCGBIOS" is not disabled - because, unlike G505S, this AM1I-A motherboard supports a TPM addition - so a size reduction is about 4x times smaller. Still it would be nice to get both of these patches merged.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33871 )
Change subject: src/mainboard/asus/am1i-a: Disable SeaBIOS options not supported by hardware ......................................................................
Patch Set 1: Code-Review+2
See commit-message comments in CB:33870.
Hello build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33871
to look at the new patch set (#2).
Change subject: mb/asus/am1i-a: Disable SeaBIOS options unsupported by hardware ......................................................................
mb/asus/am1i-a: Disable SeaBIOS options unsupported by hardware
AM1I-A does not have any SAS or NVMe controllers, so it makes sense to disable the related SeaBIOS options for this board. This reduces the size of compiled SeaBIOS by 129344-124096 = 5248 bytes.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I5ddf695f4f349697d08a685fa04c90d3afd723c5 --- M src/mainboard/asus/am1i-a/Kconfig A src/mainboard/asus/am1i-a/config_seabios 2 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33871/2
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33871 )
Change subject: mb/asus/am1i-a: Disable SeaBIOS options unsupported by hardware ......................................................................
Patch Set 2:
Patch Set 1: Code-Review+2
See commit-message comments in CB:33870.
Done, hope it's good now.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33871 )
Change subject: mb/asus/am1i-a: Disable SeaBIOS options unsupported by hardware ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
*Not* blocking submit with this -1.
https://review.coreboot.org/c/coreboot/+/33871/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33871/2//COMMIT_MSG@9 PS2, Line 9: does not have any SAS or NVMe controllers It does have a PCIe x4 port in which you can plug both of these: most MegaRAID SAS controllers are PCIe, and you can plug in a M.2 NVMe SSD with an adapter card, e.g., [1].
[1]: https://www.storagereview.com/images/StorageReview-Netstor-Adaptor.jpg
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33871 )
Change subject: mb/asus/am1i-a: Disable SeaBIOS options unsupported by hardware ......................................................................
Patch Set 2: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/33871/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33871/2//COMMIT_MSG@9 PS2, Line 9: does not have any SAS or NVMe controllers
It does have a PCIe x4 port in which you can plug both of these: most MegaRAID SAS controllers are P […]
Uh, thanks, you are right. I assumed by the commit message that this isn't a desktop board. In the light of this, I don't see how this change makes any sense.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33871 )
Change subject: mb/asus/am1i-a: Disable SeaBIOS options unsupported by hardware ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33871/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33871/2//COMMIT_MSG@9 PS2, Line 9: does not have any SAS or NVMe controllers
Uh, thanks, you are right. I assumed by the commit message that this […]
Sorry, I forgot about the PCIe add-on cards! Okay, I'm abandoning this change...
Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33871 )
Change subject: mb/asus/am1i-a: Disable SeaBIOS options unsupported by hardware ......................................................................
Abandoned
AM1I-A has a PCIe port where a card with SAS or NVMe controller could be installed.
Mike Banon has restored this change. ( https://review.coreboot.org/c/coreboot/+/33871 )
Change subject: mb/asus/am1i-a: Disable SeaBIOS options unsupported by hardware ......................................................................
Restored
Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33871 )
Change subject: mb/asus/am1i-a: Disable SeaBIOS options unsupported by hardware ......................................................................
Abandoned
Mike Banon has restored this change. ( https://review.coreboot.org/c/coreboot/+/33871 )
Change subject: mb/asus/am1i-a: Disable SeaBIOS options unsupported by hardware ......................................................................
Restored
Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33871 )
Change subject: mb/asus/am1i-a: Disable SeaBIOS options unsupported by hardware ......................................................................
Abandoned
-
Angel Pons (Code Review) -
Mike Banon (Code Review)
-
Nico Huber (Code Review)