Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: [WIP] 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
[WIP] 3rdparty/libgfxinit: Update for Cannon Point support
We missed that Cannon Point, the PCH usually paired with Coffee, Whiskey and Comet Lake, differs a bit from its predecessors. Hence, libgfxinit has a new Kconfig setting now for the PCH.
[WIP] as the libgfxinit patches are still under review.
Change-Id: I1c02c0d9abb7340aabe94185ee5e17ef4c2b0d36 Signed-off-by: Nico Huber nico.h@gmx.de --- M 3rdparty/libgfxinit M src/drivers/intel/gma/Kconfig 2 files changed, 10 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/48764/1
diff --git a/3rdparty/libgfxinit b/3rdparty/libgfxinit index 3318bf2..b9e792e 160000 --- a/3rdparty/libgfxinit +++ b/3rdparty/libgfxinit @@ -1 +1 @@ -Subproject commit 3318bf26803c77d41b18bef6d7ae4e051b97f9f2 +Subproject commit b9e792ee73407d518d6c1b7c6ecdbe925a001ec8 diff --git a/src/drivers/intel/gma/Kconfig b/src/drivers/intel/gma/Kconfig index 3f75ab9..f9423f0 100644 --- a/src/drivers/intel/gma/Kconfig +++ b/src/drivers/intel/gma/Kconfig @@ -119,6 +119,15 @@ default "Ironlake" if NORTHBRIDGE_INTEL_IRONLAKE || NORTHBRIDGE_INTEL_SANDYBRIDGE default "G45" if NORTHBRIDGE_INTEL_GM45 || NORTHBRIDGE_INTEL_X4X
+config GFX_GMA_PCH + string + default "Ibex_Peak" if NORTHBRIDGE_INTEL_IRONLAKE + default "Cougar_Point" if NORTHBRIDGE_INTEL_SANDYBRIDGE + default "Lynx_Point" if NORTHBRIDGE_INTEL_HASWELL || SOC_INTEL_BROADWELL + default "Sunrise_Point" if SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE + default "Cannon_Point" if SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE + default "No_PCH" + config GFX_GMA_PANEL_1_PORT string default "eDP" if GFX_GMA_PANEL_1_ON_EDP
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: [WIP] 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/48764/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48764/1//COMMIT_MSG@10 PS1, Line 10: Hence, libgfxinit : has a new Kconfig setting now for the PCH. I'd move `now` earlier in the sentence:
Hence, libgfxinit *now* has a new Kconfig setting for the PCH.
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... PS1, Line 128: default "Cannon_Point" if SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE Does `Cannon_Point` also apply to SOC_INTEL_COMETLAKE ?
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: [WIP] 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... PS1, Line 128: default "Cannon_Point" if SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE
Does `Cannon_Point` also apply to SOC_INTEL_COMETLAKE ?
yes
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: [WIP] 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... PS1, Line 128: default "Cannon_Point" if SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE
yes
Even if it doesn't, it's most certainly less wrong than `No_PCH` 😜
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: [WIP] 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... PS1, Line 128: default "Cannon_Point" if SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE
Even if it doesn't, it's most certainly less wrong than `No_PCH` 😜
It's not in the list above yet, hence didn't add it here.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: [WIP] 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... PS1, Line 128: default "Cannon_Point" if SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE
It's not in the list above yet, hence didn't add it here.
see CB:40720
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: [WIP] 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48764/1/3rdparty/libgfxinit File 3rdparty/libgfxinit:
https://review.coreboot.org/c/coreboot/+/48764/1/3rdparty/libgfxinit@1 PS1, Line 1: b9e792ee73407d should be e2c57a60aa8d774039ebb2e9929a6028c8233fa3 / CB:48770
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: [WIP] 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... PS1, Line 127: SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE SOC_INTEL_COMMON_SKYLAKE_BASE
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... PS1, Line 128: SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE SOC_INTEL_CANNONLAKE_BASE
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: [WIP] 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... PS1, Line 128: default "Cannon_Point" if SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE
see CB:40720
SOC_INTEL_COMETLAKE can be added now
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: [WIP] 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48764/1/3rdparty/libgfxinit File 3rdparty/libgfxinit:
https://review.coreboot.org/c/coreboot/+/48764/1/3rdparty/libgfxinit@1 PS1, Line 1: b9e792ee73407d
should be e2c57a60aa8d774039ebb2e9929a6028c8233fa3 / CB:48770
The correct hash can only be known once the libgfxinit changes are merged. This is why there's [WIP] labels in the commit message.
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... PS1, Line 127: SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE
SOC_INTEL_COMMON_SKYLAKE_BASE
I'd prefer to leave this as-is on this patch, and change this instance and the one for GFX_GMA_GENERATION in a follow-up.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: [WIP] 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/48764/1/3rdparty/libgfxinit File 3rdparty/libgfxinit:
https://review.coreboot.org/c/coreboot/+/48764/1/3rdparty/libgfxinit@1 PS1, Line 1: b9e792ee73407d
The correct hash can only be known once the libgfxinit changes are merged. […]
Ack
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... PS1, Line 127: SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE
I'd prefer to leave this as-is on this patch, and change this instance and the one for GFX_GMA_GENER […]
let's merge as-is and revisit, when CNL got dropped
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... PS1, Line 128: default "Cannon_Point" if SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE
SOC_INTEL_COMETLAKE can be added now
let's merge as-is and revisit, when CNL got dropped
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... PS1, Line 128: SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE
SOC_INTEL_CANNONLAKE_BASE
let's merge as-is and revisit, when CNL got dropped
Hello build bot (Jenkins), Angel Pons, Michael Niewöhner, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48764
to look at the new patch set (#2).
Change subject: 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
3rdparty/libgfxinit: Update for Cannon Point support
We missed that Cannon Point, the PCH usually paired with Coffee, Whiskey and Comet Lake, differs a bit from its predecessors. Hence, libgfxinit now has a new Kconfig setting for the PCH.
Change-Id: I1c02c0d9abb7340aabe94185ee5e17ef4c2b0d36 Signed-off-by: Nico Huber nico.h@gmx.de --- M 3rdparty/libgfxinit M src/drivers/intel/gma/Kconfig 2 files changed, 10 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/48764/2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48764/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48764/1//COMMIT_MSG@10 PS1, Line 10: Hence, libgfxinit : has a new Kconfig setting now for the PCH.
I'd move `now` earlier in the sentence: […]
Done
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... PS1, Line 127: SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE
let's merge as-is and revisit, when CNL got dropped
Done (I think it's ok to have a value even for Cannon Lake here, only the guarding dependencies above would be problematic).
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... PS1, Line 128: SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE
let's merge as-is and revisit, when CNL got dropped
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
Patch Set 2: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
Patch Set 3: Code-Review+2
Michael Niewöhner has uploaded a new patch set (#6) to the change originally created by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
3rdparty/libgfxinit: Update for Cannon Point support
We missed that Cannon Point, the PCH usually paired with Coffee, Whiskey and Comet Lake, differs a bit from its predecessors. Hence, libgfxinit now has a new Kconfig setting for the PCH.
Change-Id: I1c02c0d9abb7340aabe94185ee5e17ef4c2b0d36 Signed-off-by: Nico Huber nico.h@gmx.de --- M 3rdparty/libgfxinit M src/drivers/intel/gma/Kconfig 2 files changed, 10 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/48764/6
Michael Niewöhner has uploaded a new patch set (#14) to the change originally created by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
3rdparty/libgfxinit: Update for Cannon Point support
We missed that Cannon Point, the PCH usually paired with Coffee, Whiskey and Comet Lake, differs a bit from its predecessors. Hence, libgfxinit now has a new Kconfig setting for the PCH.
Change-Id: I1c02c0d9abb7340aabe94185ee5e17ef4c2b0d36 Signed-off-by: Nico Huber nico.h@gmx.de --- M 3rdparty/libgfxinit M src/drivers/intel/gma/Kconfig 2 files changed, 10 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/48764/14
Michael Niewöhner has uploaded a new patch set (#16) to the change originally created by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
3rdparty/libgfxinit: Update for Cannon Point support
We missed that Cannon Point, the PCH usually paired with Coffee, Whiskey and Comet Lake, differs a bit from its predecessors. Hence, libgfxinit now has a new Kconfig setting for the PCH.
Change-Id: I1c02c0d9abb7340aabe94185ee5e17ef4c2b0d36 Signed-off-by: Nico Huber nico.h@gmx.de --- M 3rdparty/libgfxinit M src/drivers/intel/gma/Kconfig 2 files changed, 10 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/48764/16
Michael Niewöhner has uploaded a new patch set (#17) to the change originally created by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
3rdparty/libgfxinit: Update for Cannon Point support
We missed that Cannon Point, the PCH usually paired with Coffee, Whiskey and Comet Lake, differs a bit from its predecessors. Hence, libgfxinit now has a new Kconfig setting for the PCH.
Change-Id: I1c02c0d9abb7340aabe94185ee5e17ef4c2b0d36 Signed-off-by: Nico Huber nico.h@gmx.de --- M 3rdparty/libgfxinit M src/drivers/intel/gma/Kconfig 2 files changed, 10 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/48764/17
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
3rdparty/libgfxinit: Update for Cannon Point support
We missed that Cannon Point, the PCH usually paired with Coffee, Whiskey and Comet Lake, differs a bit from its predecessors. Hence, libgfxinit now has a new Kconfig setting for the PCH.
Change-Id: I1c02c0d9abb7340aabe94185ee5e17ef4c2b0d36 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/48764 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner foss@mniewoehner.de Reviewed-by: Angel Pons th3fanbus@gmail.com --- M 3rdparty/libgfxinit M src/drivers/intel/gma/Kconfig 2 files changed, 10 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Michael Niewöhner: Looks good to me, approved
diff --git a/3rdparty/libgfxinit b/3rdparty/libgfxinit index 3318bf2..bc0588e 160000 --- a/3rdparty/libgfxinit +++ b/3rdparty/libgfxinit @@ -1 +1 @@ -Subproject commit 3318bf26803c77d41b18bef6d7ae4e051b97f9f2 +Subproject commit bc0588e482b1320d5739900b00a45033f5b587f4 diff --git a/src/drivers/intel/gma/Kconfig b/src/drivers/intel/gma/Kconfig index 3f75ab9..e13663f 100644 --- a/src/drivers/intel/gma/Kconfig +++ b/src/drivers/intel/gma/Kconfig @@ -119,6 +119,15 @@ default "Ironlake" if NORTHBRIDGE_INTEL_IRONLAKE || NORTHBRIDGE_INTEL_SANDYBRIDGE default "G45" if NORTHBRIDGE_INTEL_GM45 || NORTHBRIDGE_INTEL_X4X
+config GFX_GMA_PCH + string + default "Ibex_Peak" if NORTHBRIDGE_INTEL_IRONLAKE + default "Cougar_Point" if NORTHBRIDGE_INTEL_SANDYBRIDGE + default "Lynx_Point" if NORTHBRIDGE_INTEL_HASWELL || SOC_INTEL_BROADWELL + default "Sunrise_Point" if SOC_INTEL_COMMON_SKYLAKE_BASE + default "Cannon_Point" if SOC_INTEL_CANNONLAKE_BASE + default "No_PCH" + config GFX_GMA_PANEL_1_PORT string default "eDP" if GFX_GMA_PANEL_1_ON_EDP
-
Angel Pons (Code Review) -
Michael Niewöhner (Code Review)
-
Nico Huber (Code Review)