Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55675 )
Change subject: soc/intel/common/block/cse: Add BWG error recovery to EOP failure
......................................................................
Patch Set 15:
(1 comment)
File src/soc/intel/common/block/cse/cse_eop.c:
https://review.coreboot.org/c/coreboot/+/55675/comment/5f4ad737_3d8cecf9
PS14, Line 152: config_t *config = config_of_soc();
: config->HeciEnabled = 0;
ðŸ˜
Yeah, I think if the CSE/PMC is so badly broken that it cannot even be disabled, it is safer to not let the device boot. If this creates problems for any devices, we can revisit this later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55675
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06abf36a9d9d8a5f2afba6002dd5695dd2107db1
Gerrit-Change-Number: 55675
Gerrit-PatchSet: 15
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 30 Jun 2021 20:19:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment