Alex James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60233 )
Change subject: util/cbfstool: Avoid duplicate ntohll/htonll definitions ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: bsd/sysincludes.h in commonlib already defines byteswapping functions (from endian(3)). cbfstool includes this in flashmap/fmap.c; I wonder if we should include this in common.h instead of swab.h and update callers (or implement ntohl and friends in swab.h using bsd/sysincludes.h).