Change in coreboot[master]: soc/intel/bdw,nb/intel/hsw: convert panel delays to ms representation
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48958 )
Change subject: soc/intel/bdw,nb/intel/hsw: convert panel delays to ms representation ......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48958/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48958/4//COMMIT_MSG@28 PS4, Line 28:
indented tab doesn't work
guess that comment was stale? I dropped the script
https://review.coreboot.org/c/coreboot/+/48958/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48958/9//COMMIT_MSG@10 PS9, Line 10: delays
`panel delay times`?
done
https://review.coreboot.org/c/coreboot/+/48958/9/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/chip.h:
https://review.coreboot.org/c/coreboot/+/48958/9/src/northbridge/intel/haswe... PS9, Line 20: u16 gpu_panel_power_cycle_delay_ms; /* T4 time sequence */
use tabs for indentation? or maybe just rip the comments out. there […]
I didn't want to drop them here, to limit the diff to conversion only; the comments will vanish in the follow-up anyways
-
Michael Niewöhner (Code Review)