Attention is currently required from: Anil Kumar K, Bora Guvendik, Jamie Ryu, Jeremy Compostella, Jérémy Compostella, Paul Menzel, Subrata Banik.
Wonkyu Kim has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/84210?usp=email )
Change subject: intel/cmm/block: use CONFIG_SMM_TSEG_SIZE in sa_get_tseg_size function
......................................................................
Patch Set 3:
(2 comments)
File src/soc/intel/common/block/systemagent/systemagent_early.c:
https://review.coreboot.org/c/coreboot/+/84210/comment/51620cdb_b27f0321?usp... :
PS2, Line 155: return sa_get_gsm_base() - sa_get_tseg_base();
We checked internally and got recommendation not to calculate it as CONFIG_SMM_TSEG_SIZE is passed […]
FSP team mentioned that Tseg size is passed by UPD and memory map(relationship for Tesg base and gsm base) can also be changed in future silicon. So, FSP team recommend use Tseg size which is passed to UPD which is CONFIG_SMM_TSEG_SIZE.
File src/soc/intel/common/block/systemagent/systemagent_early.c:
https://review.coreboot.org/c/coreboot/+/84210/comment/7256a005_c963df5b?usp... :
PS3, Line 151: if (CONFIG_SMM_TSEG_SIZE) {
: return CONFIG_SMM_TSEG_SIZE;
: }
:
what is this for ?
If CONFIG_SMM_TSEG_SIZE is defined use CONFIG_SMM_TSEG_SIZE rather than calculation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84210?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic3d5175add1f7dc6e2c9f1c38133b36ffc59e789
Gerrit-Change-Number: 84210
Gerrit-PatchSet: 3
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Jeremy Compostella
jeremy.compostella@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jeremy Compostella
jeremy.compostella@gmail.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 12 Sep 2024 01:03:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com