[XS] Change in coreboot[main]: mb/google/rex: Fix ISH I2C pad for suspend
Attention is currently required from: Bora Guvendik, Cliff Huang, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun. Hello Bora Guvendik, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Li1 Feng, Subrata Banik, Tarun, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78179?usp=email to look at the new patch set (#4). Change subject: mb/google/rex: Fix ISH I2C pad for suspend ...................................................................... mb/google/rex: Fix ISH I2C pad for suspend During suspend, the ISH I2C transactions cannot go through because the GPIO pads remain the pervious value. The IO Standby State (IOSSTATE) needs to be changed to keep I2C bus active and functional during suspend. BUG=b:302612549 TEST=on Google/rex platform with ISH enabled, do suspend_stress_test and check that no i2c failure. Signed-off-by: Cliff Huang <cliff.huang@intel.com> Change-Id: I9a2c902ed56461f3a535428db399c2050756f2da --- M src/mainboard/google/rex/variants/rex0/fw_config.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/78179/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/78179?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9a2c902ed56461f3a535428db399c2050756f2da Gerrit-Change-Number: 78179 Gerrit-PatchSet: 4 Gerrit-Owner: Cliff Huang <cliff.huang@intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik@intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani@google.com> Gerrit-Reviewer: Jakub Czapiga <jacz@semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com> Gerrit-Reviewer: Li1 Feng <li1.feng@intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik@google.com> Gerrit-Reviewer: Tarun <tstuli@gmail.com> Gerrit-Attention: Bora Guvendik <bora.guvendik@intel.com> Gerrit-Attention: Cliff Huang <cliff.huang@intel.com> Gerrit-Attention: Eran Mitrani <mitrani@google.com> Gerrit-Attention: Jakub Czapiga <jacz@semihalf.com> Gerrit-Attention: Kapil Porwal <kapilporwal@google.com> Gerrit-Attention: Tarun <tstuli@gmail.com> Gerrit-MessageType: newpatchset
participants (1)
-
Cliff Huang (Code Review)