Attention is currently required from: Angel Pons. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55262 )
Change subject: cpu/x86/lapic: Support switching to X2APIC mode ......................................................................
Patch Set 11:
(2 comments)
Patchset:
PS8:
Where do you need is_x2apic_mode() to return false? There might be a problem with initial_lapi […]
With the rebase, there is some LAPIC ID related changes, where is_x2apic_mode() was dropped. So it may behave different now. The logs you provided were with commit hashes unknown to me.
File src/cpu/x86/lapic/lapic.c:
https://review.coreboot.org/c/coreboot/+/55262/comment/36d8a1a6_c6a15ef5 PS10, Line 37: ASSERT(CONFIG(X2APIC_RUNTIME) | use_x2apic);
Should have been a logical OR here.
Done
-
Kyösti Mälkki (Code Review)