Attention is currently required from: Ravi Kumar Bokka, mturney mturney, Arthur Heymans, Furquan Shaikh, Kyösti Mälkki, Prasad Malisetty.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57614 )
Change subject: libpayload: Export PCIe config info from coreboot to libpayload
......................................................................
Patch Set 41:
(3 comments)
File payloads/libpayload/include/sysinfo.h:
https://review.coreboot.org/c/coreboot/+/57614/comment/8a94785e_ffed7e48
PS40, Line 148: uintptr_t pci_config_info;
Move this right below mem_chip_base?
File src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h:
https://review.coreboot.org/c/coreboot/+/57614/comment/f40afaf9_081ead7a
PS40, Line 83: PCIE
PCI_INFO
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/57614/comment/5c29dec6_40196059
PS40, Line 100: cbmem_add
This should be done somewhere else in the pcie code, as the cbmem entry itself is unrelated to the coreboot table. Though I'm not sure whether we should move this to common code, or let each platform add the cbmem entry.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57614
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ca2be55b98c8d1b86576072078cdda02ac55940
Gerrit-Change-Number: 57614
Gerrit-PatchSet: 41
Gerrit-Owner: Ravi Kumar Bokka
rbokka@codeaurora.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Prasad Malisetty
pmaliset@qualcomm.corp-partner.google.com
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Ravi Kumar Bokka
rbokka@codeaurora.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Prasad Malisetty
pmaliset@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Wed, 30 Mar 2022 02:51:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment