Attention is currently required from: Felix Held, Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu, cong yang.
Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75512?usp=email )
Change subject: mb/google/geralt: Fix MIPI panel power on/off sequence
......................................................................
Patch Set 4:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75512/comment/8be6b765_32cd36b8 :
PS3, Line 10: large
larger
Done
https://review.coreboot.org/c/coreboot/+/75512/comment/1a848408_193c7a97 :
PS3, Line 11: large
larger
Done
File src/mainboard/google/geralt/panel_geralt.c:
https://review.coreboot.org/c/coreboot/+/75512/comment/c865531e_2ea9b3d3 :
PS3, Line 35: { PMIC_TPS65132_VPOS, 0x11, 0x1F },
: { PMIC_TPS65132_VNEG, 0x11, 0x1F },
: { PMIC_TPS65132_DLYX, 0x95, 0xFF },
: { PMIC_TPS65132_ASSDD, 0x5b, 0xFF }
Please write hex numbers lowercase.
Done
https://review.coreboot.org/c/coreboot/+/75512/comment/1c49005a_b226b502 :
PS3, Line 51: printk(BIOS_ERR, "Failed to setup tps65132s\n");
TPS65132 isn't a display panel, but a voltage regulator
Done, thank you.
https://review.coreboot.org/c/coreboot/+/75512/comment/9a054b5f_92d67a54 :
PS3, Line 51: setup
set up
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75512?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ccb5be04062a0516f84a054ff3f40afbf5279be
Gerrit-Change-Number: 75512
Gerrit-PatchSet: 4
Gerrit-Owner: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 05 Jun 2023 02:33:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment