Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79217?usp=email )
Change subject: acpigen.c: Add resource consumer functions for mmio
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
File src/acpi/acpigen.c:
https://review.coreboot.org/c/coreboot/+/79217/comment/e3a493f5_c4bee9ee :
PS9, Line 2325: bool is_producer
hmm, some enum type might be better here, since it makes it a bit clearer what that parameter does at the call-sites. since this function is static and the two call sites are nearby, it's probably fine though
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79217?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id9e4adcd976e1f56ef7f502d9df16dbefce95c3e
Gerrit-Change-Number: 79217
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 23 Nov 2023 15:30:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment