Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46301 )
Change subject: soc/intel/common: drop default to enable the PIT if SeaBIOS is chosen
......................................................................
Patch Set 1:
(1 comment)
Do we really want this, though? I guess we should add a
big fat warning that this might break any option rom.
https://review.coreboot.org/c/coreboot/+/46301/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46301/1//COMMIT_MSG@11
PS1, Line 11: enable it by default anymore, when SeaBIOS gets enabled.
Looking at its code, this doesn't seem fully true. I assume, I hope
your tests can confirm, that it always uses the PM timer if advertised
by coreboot. If that is true, please just mention that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46301
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd75800678707a92110682347c7cfb93e25109a4
Gerrit-Change-Number: 46301
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 13 Oct 2020 15:12:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment