Attention is currently required from: Tim Wawrzynczak, Christian Walter, Angel Pons, Julius Werner, Jett Rink. Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63158 )
Change subject: tpm: Allow separate handling of Google Ti50 TPM ......................................................................
Patch Set 14:
(2 comments)
File src/drivers/i2c/tpm/cr50.c:
https://review.coreboot.org/c/coreboot/+/63158/comment/2635751f_68ac5b05 PS14, Line 506: TPM_CR50
`TPM_GOOGLE_CR50`
Done
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/63158/comment/3917cdec_a274ea02 PS14, Line 47: TI50
`CR50`, Nissa is the only baseboard here that uses ti50
Really? I have on my desk a device labeled "Brya Proto2 SKU9", which came equipped with a Ti50 chip. (it use the brya4es variant, as far as I recall.)
Are you saying that the Brya baseboard variously has Cr50 and Ti50 among its protos and SKUs? If so, then I think we need to reconsider a dynamic detection approach based on DID:VID, rather taking Cr50/Ti50 branches via Kconfig.
-
Jes Klinke (Code Review)