Change in coreboot[master]: mb/google/octopus: fix droid lte sku load specific wifi sar value
Sheng-Liang Pan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47697 )
Change subject: mb/google/octopus: fix droid lte sku load specific wifi sar value ......................................................................
mb/google/octopus: fix droid lte sku load specific wifi sar value
This CL add droid lte sku 37 38 39 40 to load wifi_sar-droid.hex.
BUG=none BRANCH=octopus TEST=emerge-octopus coreboot
Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: I55dda85b8f3e664d97834b712a2c6a48d1434010 --- M src/mainboard/google/octopus/variants/bobba/variant.c 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/47697/1
diff --git a/src/mainboard/google/octopus/variants/bobba/variant.c b/src/mainboard/google/octopus/variants/bobba/variant.c index 96806a0..891da32 100644 --- a/src/mainboard/google/octopus/variants/bobba/variant.c +++ b/src/mainboard/google/octopus/variants/bobba/variant.c @@ -21,8 +21,9 @@ const char *filename = NULL; uint32_t sku_id = google_chromeec_get_board_sku();
- if (sku_id == 33 || sku_id == 34 || sku_id == 35 || sku_id == 36 || sku_id == 41 || - sku_id == 42 || sku_id == 43 || sku_id == 44) + if (sku_id == 33 || sku_id == 34 || sku_id == 35 || sku_id == 36 || sku_id == 37 || + sku_id == 38 || sku_id == 39 || sku_id == 40 || sku_id == 41 || sku_id == 42 || + sku_id == 43 || sku_id == 44) filename = "wifi_sar-droid.hex";
return filename;
Sheng-Liang Pan has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/47697 )
Change subject: mb/google/octopus: fix droid lte sku load specific wifi sar value ......................................................................
mb/google/octopus: fix droid lte sku load specific wifi sar value
This CL add droid lte sku 37 38 39 40 to load wifi_sar-droid.hex.
BUG=b:138091179 BRANCH=octopus TEST=emerge-octopus coreboot
Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: I55dda85b8f3e664d97834b712a2c6a48d1434010 --- M src/mainboard/google/octopus/variants/bobba/variant.c 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/47697/2
Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47697 )
Change subject: mb/google/octopus: fix droid lte sku load specific wifi sar value ......................................................................
Patch Set 2: Code-Review+1
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47697 )
Change subject: mb/google/octopus: fix droid lte sku load specific wifi sar value ......................................................................
Patch Set 2: Code-Review+2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47697 )
Change subject: mb/google/octopus: fix droid lte sku load specific wifi sar value ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47697/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/bobba/variant.c:
https://review.coreboot.org/c/coreboot/+/47697/2/src/mainboard/google/octopu... PS2, Line 24: if (sku_id == 33 || sku_id == 34 || sku_id == 35 || sku_id == 36 || sku_id == 37 || : sku_id == 38 || sku_id == 39 || sku_id == 40 || sku_id == 41 || sku_id == 42 || : sku_id == 43 || sku_id == 44) Looking at the continuity in the sku_id, can be simplified as
if (sku_id >= 33 && sku_id <= 44) filename = "wifi_sar-droid.hex";
Hello build bot (Jenkins), Furquan Shaikh, Justin TerAvest, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47697
to look at the new patch set (#3).
Change subject: mb/google/octopus: fix droid lte sku load specific wifi sar value ......................................................................
mb/google/octopus: fix droid lte sku load specific wifi sar value
This CL add droid lte sku 37 38 39 40 to load wifi_sar-droid.hex.
BUG=none BRANCH=octopus TEST=emerge-octopus coreboot
Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: I55dda85b8f3e664d97834b712a2c6a48d1434010 --- M src/mainboard/google/octopus/variants/bobba/variant.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/47697/3
Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47697 )
Change subject: mb/google/octopus: fix droid lte sku load specific wifi sar value ......................................................................
Patch Set 3: Code-Review+1
Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47697 )
Change subject: mb/google/octopus: fix droid lte sku load specific wifi sar value ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47697/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/bobba/variant.c:
https://review.coreboot.org/c/coreboot/+/47697/2/src/mainboard/google/octopu... PS2, Line 24: if (sku_id == 33 || sku_id == 34 || sku_id == 35 || sku_id == 36 || sku_id == 37 || : sku_id == 38 || sku_id == 39 || sku_id == 40 || sku_id == 41 || sku_id == 42 || : sku_id == 43 || sku_id == 44)
Looking at the continuity in the sku_id, can be simplified as […]
done, thanks for suggestion.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47697 )
Change subject: mb/google/octopus: fix droid lte sku load specific wifi sar value ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47697 )
Change subject: mb/google/octopus: fix droid lte sku load specific wifi sar value ......................................................................
mb/google/octopus: fix droid lte sku load specific wifi sar value
This CL add droid lte sku 37 38 39 40 to load wifi_sar-droid.hex.
BUG=none BRANCH=octopus TEST=emerge-octopus coreboot
Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: I55dda85b8f3e664d97834b712a2c6a48d1434010 Reviewed-on: https://review.coreboot.org/c/coreboot/+/47697 Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/octopus/variants/bobba/variant.c 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Sheng-Liang Pan: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/bobba/variant.c b/src/mainboard/google/octopus/variants/bobba/variant.c index 96806a0..2d09270 100644 --- a/src/mainboard/google/octopus/variants/bobba/variant.c +++ b/src/mainboard/google/octopus/variants/bobba/variant.c @@ -21,8 +21,7 @@ const char *filename = NULL; uint32_t sku_id = google_chromeec_get_board_sku();
- if (sku_id == 33 || sku_id == 34 || sku_id == 35 || sku_id == 36 || sku_id == 41 || - sku_id == 42 || sku_id == 43 || sku_id == 44) + if (sku_id >= 33 && sku_id <= 44) filename = "wifi_sar-droid.hex";
return filename;
-
Justin TerAvest (Code Review) -
Karthik Ramasubramanian (Code Review)
-
Patrick Georgi (Code Review)
-
Sheng-Liang Pan (Code Review)