Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35913 )
Change subject: util/inteltool/cpu: fix IA32_PLATFORM_ID MSR addr ......................................................................
util/inteltool/cpu: fix IA32_PLATFORM_ID MSR addr
According to the documentation [1], IA32_PLATFORM_ID MSR register address should be 17H.
[1] Table 2-2. Intel (R) 64 and IA-32 Architectures Software Developer’s Manual. Volume 4: Model-Specific Registers. May 2019. Order Number: 335592-070US
Change-Id: I9a16b162db51d21c7849b3c08c987ab341845b1e Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M util/inteltool/cpu.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/35913/1
diff --git a/util/inteltool/cpu.c b/util/inteltool/cpu.c index d2c8ede..12b7dcb 100644 --- a/util/inteltool/cpu.c +++ b/util/inteltool/cpu.c @@ -1539,7 +1539,7 @@ */
static const msr_entry_t model96ex_global_msrs[] = { - { 0x0000, "IA32_PLATFORM_ID"}, + { 0x0017, "IA32_PLATFORM_ID"}, { 0x0080, "MSR_TRACE_HUB_STH_ACPIBAR_BASE"}, { 0x00CE, "MSR_PLATFORM_INFO"}, { 0x0198, "IA32_PERF_STATUS"},
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35913 )
Change subject: util/inteltool/cpu: fix IA32_PLATFORM_ID MSR addr ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35913 )
Change subject: util/inteltool/cpu: fix IA32_PLATFORM_ID MSR addr ......................................................................
util/inteltool/cpu: fix IA32_PLATFORM_ID MSR addr
According to the documentation [1], IA32_PLATFORM_ID MSR register address should be 17H.
[1] Table 2-2. Intel (R) 64 and IA-32 Architectures Software Developer’s Manual. Volume 4: Model-Specific Registers. May 2019. Order Number: 335592-070US
Change-Id: I9a16b162db51d21c7849b3c08c987ab341845b1e Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35913 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M util/inteltool/cpu.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/util/inteltool/cpu.c b/util/inteltool/cpu.c index 75c7dae..446fd82 100644 --- a/util/inteltool/cpu.c +++ b/util/inteltool/cpu.c @@ -1539,7 +1539,7 @@ */
static const msr_entry_t model96ex_global_msrs[] = { - { 0x0000, "IA32_PLATFORM_ID"}, + { 0x0017, "IA32_PLATFORM_ID"}, { 0x0080, "MSR_TRACE_HUB_STH_ACPIBAR_BASE"}, { 0x00CE, "MSR_PLATFORM_INFO"}, { 0x0198, "IA32_PERF_STATUS"},
-
Felix Held (Code Review) -
Maxim Polyakov (Code Review)