Attention is currently required from: Bartłomiej Grzesik, Julius Werner, Konrad Adamczyk, Yu-Ping Wu.
Paul Menzel has posted comments on this change by Bartłomiej Grzesik. ( https://review.coreboot.org/c/coreboot/+/87107?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: Add allocation of a buffer for pvmfw within cbmem
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87107/comment/d183d9bf_f0510f92?usp... :
PS3, Line 9: his change adds
Add …
https://review.coreboot.org/c/coreboot/+/87107/comment/bc001915_37f32b38?usp... :
PS3, Line 17: TEST=Check if pvmfw buffer is available for depthcharge
How do you check it?
File src/vendorcode/google/Kconfig:
https://review.coreboot.org/c/coreboot/+/87107/comment/4370d1ae_b6ac7bcf?usp... :
PS3, Line 45: pvmfw
Please elaborate in the description.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87107?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I48efc033ac0f5fbfcf3a52fabf40be016cd4c6f7
Gerrit-Change-Number: 87107
Gerrit-PatchSet: 3
Gerrit-Owner: Bartłomiej Grzesik
bgrzesik@google.com
Gerrit-Reviewer: Jakub "Kuba" Czapiga
czapiga@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Konrad Adamczyk
konrada@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Konrad Adamczyk
konrada@google.com
Gerrit-Attention: Bartłomiej Grzesik
bgrzesik@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 03 Apr 2025 11:45:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No