Hao Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48948 )
Change subject: mb/google/volteer: Copano: Update SPD table
......................................................................
Patch Set 4:
Patch Set 3:
Do you use gen_part_id to generate the setting?
I used gen_part_id to generate the memory settings, and then upload the patch again.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48948
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ace17e8fff12d3f5de15a35f609265d8b6ed6b2
Gerrit-Change-Number: 48948
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Chou
hao_chou@pegatron.corp-partner.google.com
Gerrit-Reviewer: Hao Chou
hao_chou@pegatron.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Mon, 04 Jan 2021 09:31:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment