Attention is currently required from: Frans Hendriks, Piotr Król.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49972 )
Change subject: mb/pcengines/apu2/Kconfig: Remove APU2_PINMUX_OFF_X
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
They are actually used indirectly. See https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/pcengines/a...
So when the PINMUX_OFF is selected, neither GPIO nor UART is enabled, so it is an equivalent of "DO NOTHING". If we are to remove it, there must be an equivalent in the code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49972
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf297e80865eff0d73fc0ef7a499dacf03fb3e5d
Gerrit-Change-Number: 49972
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Wed, 27 Jan 2021 10:36:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment