Attention is currently required from: Lance Zhao, Francois Toguo Fotso, Martin Roth, Tim Wawrzynczak, Nikunj Dadhania, Patrick Rudolph.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49799 )
Change subject: This implements the ACPI BERT generation.
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
Patchset:
PS5:
The code looks sounds but I guess it would be useful to see how all this is used.
For example, if acpi_is_boot_error_src_present() is just a per-SoC return false/true thing, we might be better off with if (ENABLED(ACPI_BERT)) or something like that.
Also the commit message talks about BERT but the change also covers crashlog structures that seem to be distinct (given that they have their own cbmem entries), so not entirely sure what's up with that yet.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00e390d735d61beac2e89a726e39119d9b06b3df
Gerrit-Change-Number: 49799
Gerrit-PatchSet: 5
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nikunj Dadhania
nikunj.dadhania@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Raj Astekar
raj.astekar@intel.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nikunj Dadhania
nikunj.dadhania@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 26 Jan 2021 10:22:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment