Attention is currently required from: Arthur Heymans, Felix Held, Martin Roth.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76508?usp=email )
Change subject: soc/amd/genoa: Enable eSPI early ......................................................................
Patch Set 5:
(4 comments)
File src/mainboard/amd/onyx/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/76508/comment/90e4b766_03e35966 : PS4, Line 19: device cpu_cluster 0 on end
not needed, since we already have that in the chipset devicetree
Done
File src/soc/amd/genoa/Kconfig:
https://review.coreboot.org/c/coreboot/+/76508/comment/5170d2a3_ba725e9b : PS3, Line 27:
Nit: remove extra line?
Done
File src/soc/amd/genoa/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/76508/comment/224bcc94_19d9a749 : PS3, Line 5:
might be good to remove this second empty line
Done
https://review.coreboot.org/c/coreboot/+/76508/comment/b8420d14_a451a8e3 : PS3, Line 21:
oh, looks like the common lpc_util has its own definition for the lpc device
Done